Skip to content

Fix: Add missing ServerboundAttackPacket to PacketUtils#6376

Open
Haykkonen wants to merge 1 commit intoMeteorDevelopment:masterfrom
Haykkonen:master
Open

Fix: Add missing ServerboundAttackPacket to PacketUtils#6376
Haykkonen wants to merge 1 commit intoMeteorDevelopment:masterfrom
Haykkonen:master

Conversation

@Haykkonen
Copy link
Copy Markdown

Description

Added ServerboundAttackPacket to PacketUtils maps (C2S_PACKETS and C2S_PACKETS_R).

Since Mojang split the old interact packet into interaction and attack in recent versions, ServerboundAttackPacket was completely missing from the internal PacketUtils list. This caused issues where users couldn't select or filter this packet in the UI (e.g., inside the PacketListSetting used by modules like PacketDelay or PacketCancel), making it impossible to cancel or delay attacks via the GUI.

Guidelines

  • The license header is preserved.
  • No IDE/system-related files are included.
  • Code style matches the existing project structure.

Copilot AI review requested due to automatic review settings May 1, 2026 07:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missing client-to-server packet registration in PacketUtils, ensuring ServerboundAttackPacket is available wherever the client uses PacketUtils’ name↔class maps (e.g., packet filtering/selection UIs such as PacketListSetting).

Changes:

  • Add ServerboundAttackPacket to the C2S_PACKETS map (class → display name).
  • Add ServerboundAttackPacket to the C2S_PACKETS_R map (display name → class).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@crosby-moe
Copy link
Copy Markdown
Collaborator

was the copilot overview really necessary

@necessaryafter
Copy link
Copy Markdown

lgtm

@Haykkonen
Copy link
Copy Markdown
Author

was the copilot overview really necessary

@crosby-moe i didn't trigger it manually haha. it's actually an automatic feature that triggers by default on my prs since i use github pro / copilot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants