Fix: Add missing ServerboundAttackPacket to PacketUtils#6376
Open
Haykkonen wants to merge 1 commit intoMeteorDevelopment:masterfrom
Open
Fix: Add missing ServerboundAttackPacket to PacketUtils#6376Haykkonen wants to merge 1 commit intoMeteorDevelopment:masterfrom
Haykkonen wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a missing client-to-server packet registration in PacketUtils, ensuring ServerboundAttackPacket is available wherever the client uses PacketUtils’ name↔class maps (e.g., packet filtering/selection UIs such as PacketListSetting).
Changes:
- Add
ServerboundAttackPacketto theC2S_PACKETSmap (class → display name). - Add
ServerboundAttackPacketto theC2S_PACKETS_Rmap (display name → class).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
was the copilot overview really necessary |
|
lgtm |
Author
@crosby-moe i didn't trigger it manually haha. it's actually an automatic feature that triggers by default on my prs since i use github pro / copilot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
ServerboundAttackPackettoPacketUtilsmaps (C2S_PACKETSandC2S_PACKETS_R).Since Mojang split the old interact packet into interaction and attack in recent versions,
ServerboundAttackPacketwas completely missing from the internal PacketUtils list. This caused issues where users couldn't select or filter this packet in the UI (e.g., inside thePacketListSettingused by modules likePacketDelayorPacketCancel), making it impossible to cancel or delay attacks via the GUI.Guidelines