Unify regions stations#154
Conversation
Co-authored-by: Francesco Zanetta <62377868+frazane@users.noreply.github.com> Co-authored-by: Michele Cattaneo <44707621+MicheleCattaneo@users.noreply.github.com> Co-authored-by: Hugues de Laroussilhe <hugues.delaroussilhe@meteoswiss.ch>
…d (as in baseline)
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
Co-authored-by: Daniele Nerini <daniele.nerini@meteoswiss.ch>
frazane
left a comment
There was a problem hiding this comment.
Very nice. Fully support moving away from marimo notebooks here, I don't think they fit the use case. We might bring them back in the future for other more interactive things.
| } | ||
|
|
||
|
|
||
| try: |
There was a problem hiding this comment.
The try-except logic is duplicated
|
Hi @cosunae Thanks for pushing this. Could you maybe rearrange the commits so that git(hub) understands that the files have been renamed? Otherwise it's impossible to identify changes made to the scripts. I could give you a hand if need be, just let me know (don't want to interfere with your work, as the fix will rewrite history). |
I will try, yes, but I think it wont help with the review because the files are very different (Inherently because the structure of a marimo and python file are). |
3d9465f to
c3775ad
Compare
c3775ad to
c1f758b
Compare
|
done, after rewriting the git history with a git mv and a force push, still similarity is very small, so PR will refuse to show it as a diff |
Thanks and sorry for putting you on this. I didn't think about the python script / marimo issue |
When calling the showcase with a number of regions (for the plots) and locations for meteograms, currently we launch 1 task per region and location. While this maximizes parallelism, it is not efficient given these tasks are mostly IO bound that they will load the same data (entire horizontal plane) multiples times in order to select later on the region/location.
In this PR we modify the following:
TO BE MERGED AFTER #144