fix: proper handling of partially-identified txs to 'unidentified'#42
Merged
fix: proper handling of partially-identified txs to 'unidentified'#42
Conversation
erwolff
reviewed
Apr 21, 2026
| } | ||
|
|
||
| if (!transaction.logs || !transaction.logs.length || !transaction.methodId) { | ||
| if ((!transaction.logs || !transaction.logs.length) && !transaction.methodId) { |
There was a problem hiding this comment.
nit: could be shortened to if (!transaction.logs?.length && !transaction.methodId) { but it's fine like this as well ofc
erwolff
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Adjusts V6 fallback classification logic, which can change how some transactions are labeled (STANDARD vs CONTRACT_CALL) in user-facing history; impact should be limited but touches core categorization behavior.
Overview
Fixes V6 fallback categorization so transactions with a
methodIdbut no logs are treated asGENERIC_CONTRACT_CALL/CONTRACT_CALL(readable: "Unidentified Transaction") instead of being downgraded toSTANDARD.Adds a regression test and nock fixture for an ENS
commit()transaction that has amethodIdbut emits no logs to ensure this behavior stays correct.Reviewed by Cursor Bugbot for commit ff6eab3. Bugbot is set up for automated code reviews on this repo. Configure here.