Conversation
erwolff
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how Ethereum addresses are displayed in transaction approval messages by truncating long addresses for better readability. The changes ensure that both the code and test cases consistently use the shortened address format across transaction categorization and mock data.
Address formatting improvements:
truncateAddressinutils.tsto shorten Ethereum addresses, displaying the first 7 and last 5 characters with an ellipsis in between.txCategorizeV6.tsto usetruncateAddressfor thespenderfield in approval transactions, ensuring all generated approval messages use the truncated address.Test and mock data updates:
testCases.mock.tsandtxCategorize.test.ts.snapto expect and verify the new truncated address format in approval messages. [1] [2] [3] [4] [5]truncateAddressinutils.test.tsto validate its behavior with various address lengths and edge cases.