Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Adds a new heuristic mapping entry and test fixtures; low blast radius, with the main risk being misclassification if the new address/topic overlaps other patterns.
Overview
Adds support for MetaMask pooled staking “stake” transactions to
tx-categorizeby recognizing theMETAMASK_POOLED_STAKINGcontract address and a new staking-related topic hash, producing a newMETAMASK_STAKE_STAKEcategorization.Updates tests to cover the new case: adds the tx hash and expected v5/v6 labels (v6:
Staked 0.0001 ETH) and introduces a new nock fixture for the primitives API response for that transaction.Reviewed by Cursor Bugbot for commit b2d0304. Bugbot is set up for automated code reviews on this repo. Configure here.