Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core heuristic classification (contract/topic matching), which can change categorization outcomes for other transactions if priorities or matches conflict, though the change is narrow and covered by fixtures/snapshots.
Overview
Adds support for categorizing Convex reward-claim transactions as
CONVEX_CLAIMby recognizing the Convex staked CVX reward pool contract and theRewardPaidlog topic as aCLAIMsignal.Updates the ethereum test suite to include a new
CONVEX_CLAIMcase (mock tx hash, expected v5/v6 readable labels, and snapshot) and adds a matching nock fixture for the transaction API response.Reviewed by Cursor Bugbot for commit 8170913. Bugbot is set up for automated code reviews on this repo. Configure here.