Open
Conversation
packages/tx-categorize/src/localization/locales/en/translation.json
Outdated
Show resolved
Hide resolved
...test-fixtures/nock/1-0x1f265e39c784fb2c4e5b9a7b8f0863b631d644d1d73ea5a507adfbda6ac0ef6b.json
Outdated
Show resolved
Hide resolved
blurpesec
reviewed
Apr 14, 2026
| '0x1a88df1cfe15af22b3c4c783d4e6f7f9e0c1885d', | ||
| '0x9eda81c21c273a82be9bbc19b6a6182212068101', | ||
| ], | ||
| name: 'AAVE_V3_STAKE_TOKEN', |
Contributor
There was a problem hiding this comment.
move V3 to a version property
blurpesec
requested changes
Apr 14, 2026
Contributor
blurpesec
left a comment
There was a problem hiding this comment.
Can you add example txs for each tx type to the test-cases https://github.com/MetaMask/tx-categorize/blob/main/packages/tx-categorize/src/testCases.mock.ts
so that we maintain coverage in tests and can guarantee tx categorizations don't conflict?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f441e83. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Adds new transaction action types and broadens heuristic matching for several major DeFi protocols, which can change categorization outputs for real user transactions. Also updates/introduces multiple recorded nock fixtures, so test stability depends on those fixtures matching the current API request shape.
Overview
Expands transaction categorization for DeFi activity. Adds new
ActiontypesCOLLECTandMODIFY_LIQUIDITY(with i18n labels across locales) and updates heuristic determinants to recognize Uniswap V3collectand liquidity modifications, plus Uniswap V4ModifyLiquidity.Broadens protocol/address/topic/method coverage. Extends the heuristic maps with additional contract identifiers and event/method signatures for Curve deposits and Convex/Aave/MetaMask staking/claiming, and standardizes several protocol naming/version fields.
Updates test corpus. Refreshes and adds
txTestCasesentries and introduces new nock fixtures for the added hashes while removing an outdated Uniswap V3 fixture.Reviewed by Cursor Bugbot for commit 29c4b8a. Bugbot is set up for automated code reviews on this repo. Configure here.