feat: update dapp connections menu naming and conditional Connections display - #45461
Draft
ameliejyc wants to merge 18 commits into
Draft
Conversation
…component and remove unused styles
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (20 files, +449 -504)
🧪 @MetaMask/qa (2 files, +32 -24)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Builds ready [22a8b8d]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
Builds ready [c511dd8]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0e22a73. Configure here.
Contributor
Builds ready [0e22a73]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 11 warn · 🔴 1 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
Contributor
Builds ready [ef1ded5] [reused from 0e22a73]
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 11 warn · 🔴 1 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
ameliejyc
changed the title
This reverts commit 5833176.
Contributor
Builds ready [e80e65a]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 7 warn · 🔴 2 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Menu item changed from Dapp connections to Permissions:
Site permissions header is changed from Sites to Permissions:
Empty state copy updated:
Gator permissions page styles and copy updated:
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Copy, navigation, and presentation changes in settings/permissions UI with no auth or transaction logic changes; redirect/back behavior is the main behavioral surface to verify manually.
Overview
Renames the connected-sites entry in the global menu from Dapp connections to Permissions, and aligns permission-related screens to the same Permissions header instead of Sites / Dapp Connections.
On the Gator permissions hub, site access is grouped under a Dapps label with a Connections row (replacing Sites), and the page auto-redirects to the connections list when the user only has dapp connections and no Gator asset permissions. Back navigation on the connections list is adjusted (
navigate(-1)when opened from home) so returning from connections can go straight home when the hub was skipped.Empty states are unified via a new
PermissionsEmptyState(title Nothing to see here, shorter description) and wired into connections, Gator hub, review, and token-transfer pages. Locale files drop obsolete keys (allPermissions,dappConnections,sites) and addconnections,dapps, andpermissionsPageEmptyTitle. E2E flows now look for Connections and reflect the simplified back stack.Reviewed by Cursor Bugbot for commit e80e65a. Bugbot is set up for automated code reviews on this repo. Configure here.