Skip to content

feat!: wire NetworkEnablementController to ConfigRegistryController #9611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikesposito wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat!: wire NetworkEnablementController to ConfigRegistryController #9611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e61ffda
feat!: wire `NetworkEnablementController` to `ConfigRegistryController`
mikesposito Jul 23, 2026
7c3037b
fix: normalize chain IDs from POPULAR_NETWORKS
mikesposito Jul 23, 2026
071c206
adjust jest thresholds
mikesposito Jul 23, 2026
c86312e
fix lint
mikesposito Jul 23, 2026
5107063
update method action types
mikesposito Jul 23, 2026
ceed4a7
fix lint
mikesposito Jul 23, 2026
ba9ebe2
Merge branch 'main' into me/network-enablement-controller-dynamic-reg…
mikesposito Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ linkStyle default opacity:0.5
network_controller --> messenger;
network_controller --> remote_feature_flag_controller;
network_enablement_controller --> base_controller;
network_enablement_controller --> config_registry_controller;
network_enablement_controller --> controller_utils;
network_enablement_controller --> messenger;
network_enablement_controller --> multichain_network_controller;
Expand Down
2 changes: 2 additions & 0 deletions packages/network-enablement-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- **BREAKING:** Popular-network classification is now augmented by `ConfigRegistryController` ([#9611](https://github.com/MetaMask/core/pull/9611))
- `NetworkEnablementControllerMessenger` now requires the `ConfigRegistryController:getState` action to be available.
- Bump `@metamask/transaction-controller` from `^69.0.0` to `^69.2.1` ([#9568](https://github.com/MetaMask/core/pull/9568), [#9589](https://github.com/MetaMask/core/pull/9589), [#9593](https://github.com/MetaMask/core/pull/9593))

## [5.6.0]
Expand Down
2 changes: 1 addition & 1 deletion packages/network-enablement-controller/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ module.exports = merge(baseConfig, {
// An object that configures minimum threshold enforcement for coverage results
coverageThreshold: {
global: {
branches: 94.8,
branches: 95.18,
functions: 100,
lines: 100,
statements: 100,
Expand Down
1 change: 1 addition & 0 deletions packages/network-enablement-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
},
"dependencies": {
"@metamask/base-controller": "^9.1.0",
"@metamask/config-registry-controller": "^0.4.1",
"@metamask/controller-utils": "^12.3.0",
"@metamask/keyring-api": "^23.5.0",
"@metamask/messenger": "^2.0.0",
Expand Down
4 changes: 2 additions & 2 deletions ...ages/network-enablement-controller/src/NetworkEnablementController-method-action-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ export type NetworkEnablementControllerIsNetworkEnabledAction = {

/**
* Returns popular EVM network chain IDs in hex form, restricted to networks
* that exist in NetworkController (networkConfigurationsByChainId). Source list
* is POPULAR_NETWORKS.
* that exist in NetworkController (networkConfigurationsByChainId). Source is
* the bundled `POPULAR_NETWORKS` unioned with registry-featured EVM chains.
*
* @returns Hex chain IDs for popular EVM networks that are configured.
*/
Expand Down
Loading