docs: fix broken links and stale controller names#9610
Open
ZayanKhan-12 wants to merge 1 commit into
Open
Conversation
- assets-controllers README: CollectibleDetectionController and CollectiblesController were renamed to NftDetectionController and NftController long ago; update the entries (and keep the list alphabetical), fix a DeFiPositionsController.ts.ts double-extension typo, and point the Real-Time Balance Updates link at the doc's actual location in core-backend/docs. - core-backend real-time-balance-updates-flow doc: links were written relative to the repo root instead of the file's directory. - transaction-pay-controller ARCHITECTURE: absolute /packages/... path doesn't resolve on GitHub. - permission-controller ARCHITECTURE: PermissionController.test.ts lives in src/. - .cursor/BUGBOT.md: AGENTS.md is at the repo root. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
A mechanical link audit of every markdown file in the repo (resolving each relative link target against the filesystem) found 12 broken links across 5 files. Docs-only change; no code touched.
packages/assets-controllers/README.mdNftDetectionController/NftControllerlong ago — both links 404. Updated the names and links, and moved the two entries so the list stays alphabetical.DeFiPositionsController.ts.tsdouble-extension typo in the link target../REAL_TIME_BALANCE_UPDATES.mddoesn't exist; the doc lives atpackages/core-backend/docs/real-time-balance-updates-flow.md.packages/core-backend/docs/real-time-balance-updates-flow.md../packages/...), so they resolve to nonexistent paths from the file's directory. Also,AccountActivityService.tsandBackendWebSocketService.tslive undersrc/ws/, notsrc/.packages/transaction-pay-controller/ARCHITECTURE.md—/packages/...absolute path doesn't resolve on GitHub →./src/utils/required-tokens.ts.packages/permission-controller/ARCHITECTURE.md—./PermissionController.test.ts→./src/PermissionController.test.ts..cursor/BUGBOT.md—./AGENTS.md→../AGENTS.md(AGENTS.md is at the repo root).References
N/A — found via link audit, no tracking issue.
Changelog
Docs-only; no consumer-facing package behavior change, so no changelog entries added. Happy to add them if preferred.
Checklist
🤖 Generated with Claude Code
Note
Low Risk
Documentation-only changes with no impact on application behavior, APIs, or security-sensitive code paths.
Overview
Documentation-only fixes from a markdown link audit: 12 broken links across five files, with no runtime or package code changes.
In
packages/assets-controllers/README.md, the controller list now usesNftController/NftDetectionController(replacing stale Collectibles names), fixes theDeFiPositionsController.ts.tstypo, and points the real-time balance doc at../core-backend/docs/real-time-balance-updates-flow.md.packages/core-backend/docs/real-time-balance-updates-flow.md“References” links are corrected to paths relative to that file, includingsrc/ws/for WebSocket services.permission-controllerandtransaction-pay-controllerARCHITECTURE docs use./src/...instead of wrong root paths..cursor/BUGBOT.mdnow links to../AGENTS.mdat the repo root.Reviewed by Cursor Bugbot for commit af6958c. Bugbot is set up for automated code reviews on this repo. Configure here.