chore: pass marketCap on Trade (social-trading)#9605
Merged
Conversation
joaosantos15
approved these changes
Jul 23, 2026
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Jul 23, 2026
## Explanation Releasing a new version of social-controllers. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog-only release with no runtime code changes in this PR; the documented API addition is optional and backward compatible. > > **Overview** > Cuts **release 1143.0.0** for the core monorepo and publishes **`@metamask/social-controllers@2.6.0`**. > > The social-controllers changelog is finalized for **2.6.0**, documenting the shipped addition of an optional **`marketCap`** on the **`Trade`** type (and **`TradeStruct`**) for historical token market cap at trade time from the social API ([MetaMask#9605](MetaMask#9605)). Compare links and the `[Unreleased]` section are updated for the new tag. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 6467dbe. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Pass
marketCaptoTrade, meaningTradeStruct+Tradetype getmarketCap?: number | null..References
Checklist
Note
Low Risk
Backward-compatible optional field on trade validation/types only; no auth, persistence, or behavior changes.
Overview
Extends
Trade/TradeStructwith an optionalmarketCapfield (number | null) so consumers can show the token’s USD market cap at trade time when the social API (Clicker) provides it.The superstruct schema in
social-types.tsis updated andTradeis still derived viaInfer, so any API responses that already validate trades throughTradeStruct(e.g. positiontradesinSocialService) accept the new property without breaking older payloads that omit it. The package changelog records the addition under Unreleased.Reviewed by Cursor Bugbot for commit eab250d. Bugbot is set up for automated code reviews on this repo. Configure here.