feat(assets-controller): add snaps migration FF#9534
Merged
Kriys94 merged 2 commits intoJul 23, 2026
Conversation
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
8 times, most recently
from
July 17, 2026 09:12
2f2753c to
355b70c
Compare
Kriys94
marked this pull request as ready for review
July 17, 2026 09:37
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
from
July 20, 2026 08:25
355b70c to
44376e0
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Contributor
Author
|
Preview build PR MetaMask/metamask-extension#44601 |
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
from
July 20, 2026 14:40
44376e0 to
d7c747d
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
reviewed
Jul 23, 2026
| try { | ||
| return this.#messenger.call('RemoteFeatureFlagController:getState') | ||
| .remoteFeatureFlags; | ||
| } catch { |
Contributor
There was a problem hiding this comment.
i don't think this try/catch here is needed
Contributor
Author
There was a problem hiding this comment.
Thanks. I just removed it
salimtb
reviewed
Jul 23, 2026
| - `#getNativeAssetMap` returns a stable empty object when uncached so memoized formatters are not busted by `?? {}` identity churn | ||
| - `TokenDataSource` EVM spam filtering now uses per-chain floors from Token API `GET /v1/suggestedOccurrenceFloors` (`queryApiClient.token.fetchV1SuggestedOccurrenceFloors`) instead of a hardcoded minimum of 3 occurrences. Chains missing from the response (or a failed floors fetch) still fall back to 3 ([#9537](https://github.com/MetaMask/core/pull/9537)) | ||
| - `TokensApiClient` (used by `RpcDataSource` / `TokenDetector`) now sets the token-list `occurrenceFloor` query param from the same Token API `GET /v1/suggestedOccurrenceFloors` endpoint (cached 1h), replacing the hardcoded Linea/MegaETH/Tempo special cases. Missing chains or failed fetches fall back to 3 ([#9537](https://github.com/MetaMask/core/pull/9537)) | ||
| - Add `@metamask/remote-feature-flag-controller` as a dependency ([#9534](https://github.com/MetaMask/core/pull/9534)) |
Contributor
There was a problem hiding this comment.
this should be a breaking change as we're adding new event to the messenger now
Contributor
Author
There was a problem hiding this comment.
Good catch. In the end, I removed it because the controller was already importing the controller.
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
from
July 23, 2026 08:47
821143d to
f0616d5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0616d5. Configure here.
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
from
July 23, 2026 09:05
f0616d5 to
602a1f3
Compare
Kriys94
force-pushed
the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
from
July 23, 2026 09:17
602a1f3 to
87ff788
Compare
salimtb
approved these changes
Jul 23, 2026
Kriys94
deleted the
feat/wpn-1489-stage-gated-ingestion-migration-networks
branch
July 23, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
AssetsControllerneeds to take over assets ingestion (balances, metadata,prices) for the non-EVM networks currently owned by their Snaps — Solana,
Stellar, and Tron — but this has to happen gradually and be reversible per
network. Previously the
AssetsController/AccountsApiDataSourcehad no notionof a per-network migration state: the Accounts API data source hardcoded an
eip155-only filter for the chains it surfaced as active, so there was no safeway to stage the rollout or roll it back without a code change.
This PR adds stage-gated ingestion driven by the
RemoteFeatureFlagController, so the migration for each network can be advancedand rolled back independently via LaunchDarkly:
snaps-assets-migrationutil module defines the per-network rolloutmodel: the
SnapsAssetsMigrationStageenum (Off→ReadAssetsControllerWithFallback→
ReadAssetsControllerWithoutFallback→ReadAssetsControllerOnly), theper-network flag keys (
networkAssetsSnapsMigrationSolana,networkAssetsSnapsMigrationStellar,networkAssetsSnapsMigrationTron), andhelpers to resolve and evaluate a stage from remote feature flag state
(
parseSnapsAssetsMigrationStage,isMigrationStageActive,getSnapsAssetsMigrationNamespace,getMigrationStages,shouldSupportChain).AssetsControllerresolves each network's stage fromRemoteFeatureFlagControllerstate (read via theRemoteFeatureFlagController:getStatemessenger action). Migration networksare ingested (Account Activity WebSocket + Accounts API) only from
ReadAssetsControllerWithFallbackonward and left to the Snap when the stageis
Off— which is also the fail-safe when the flag is missing or thecontroller is unavailable. Non-migration namespaces (e.g.
eip155) are nevergated.
AccountsApiDataSourcenow gates the networks it surfaces as activechains on the same per-network stage (replacing the hardcoded
eip155-onlyfilter). It also subscribes to
RemoteFeatureFlagController:stateChange(mirroring
core-backend'sAccountActivityService) so newly-enablednetworks are picked up — and disabled ones dropped — without waiting for the
periodic refresh. A selector reduces the flags to a primitive migration-stage
signature so the handler only fires when a stage actually changes.
References
Checklist
Note
Medium Risk
Changes which non-EVM chains the Accounts API data source treats as active and can shift balance/subscription behavior at runtime when flags flip; rollout is flag-gated with
Offas the safe default.Overview
Adds per-network, LaunchDarkly-driven rollout for moving Solana, Stellar, and Tron asset ingestion from Snaps into
AssetsController, replacing the hardcodedeip155-only active-chain filter onAccountsApiDataSource.A new
snaps-assets-migrationmodule definesSnapsAssetsMigrationStage(OffthroughReadAssetsControllerOnly), flag keys (networkAssetsSnapsMigrationSolana/Stellar/Tron), and helpers such asshouldSupportChainandparseSnapsAssetsMigrationStage(missing or invalid flags default toOff). EVM chains stay ungated; migration namespaces only become active chains once stage ≥ReadAssetsControllerWithFallback.AccountsApiDataSourcefilters supported networks withshouldSupportChain, subscribes toRemoteFeatureFlagController:stateChangewith a migration-stage signature selector, and refreshes active chains when a stage changes.AssetsControllermessenger types now allow that event; migration helpers are re-exported from the package entrypoint. Tests always registerRemoteFeatureFlagController:getState(default{}).Reviewed by Cursor Bugbot for commit 87ff788. Bugbot is set up for automated code reviews on this repo. Configure here.