Skip to content

refactor: Use permission decoders from @metamask/7715-permission-types #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeffsmale90 merged 15 commits into from
Jul 28, 2026
Merged

refactor: Use permission decoders from @metamask/7715-permission-types #9164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
bb882e4
Remove permission definitions, rewrite makePermissionDecoder tests to…
jeffsmale90 Jun 15, 2026
164df42
Enforcer addresses passed to makePermissionDecoder should be case ins…
jeffsmale90 Jun 15, 2026
aa79559
Make decodePermission tests more focussed, and unit test like
jeffsmale90 Jun 16, 2026
6fc2c63
Add integration tests for all supported permission types
jeffsmale90 Jun 16, 2026
9e4f620
Remove types duplicated in @metamask/7715-permission-types
jeffsmale90 Jun 18, 2026
7055b57
Upgrade @metamask/7715-permission-types to ^0.8.0
jeffsmale90 Jul 14, 2026
63657c3
Upgrade @metamask/7715-permission-types to ^1.0.0
jeffsmale90 Jul 21, 2026
7cbbc65
Add changelog entry
jeffsmale90 Jul 14, 2026
e52cefa
Remove unnecessary toLowerCase when comparing addresses that have alr…
jeffsmale90 Jul 23, 2026
c14aa60
Merge branch 'main' into chore/permission_decoding_externalised_permi…
jeffsmale90 Jul 27, 2026
e45b777
Add .js extension to imports
jeffsmale90 Jul 27, 2026
16b0a35
Add additional handler test coverage
jeffsmale90 Jul 27, 2026
89667d3
Lining whitespace
jeffsmale90 Jul 27, 2026
59a1487
Add comment explaining checksumming
jeffsmale90 Jul 27, 2026
0ba2af8
Ensure PermissionDecodingError is thrown if either contracts aren't f…
jeffsmale90 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/gator-permissions-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

Comment thread
jeffsmale90 marked this conversation as resolved.
- Bump `@metamask/7715-permission-types` from `^0.7.1` to `^1.0.0` ([#9164](https://github.com/MetaMask/core/pull/9164))
- Use permission decoders from `@metamask/7715-permission-types`
- **BREAKING:** Drop support for `erc20-token-revocation` permission type
- Bump `@metamask/transaction-controller` from `^69.0.0` to `^69.2.1` ([#9568](https://github.com/MetaMask/core/pull/9568), [#9589](https://github.com/MetaMask/core/pull/9589), [#9593](https://github.com/MetaMask/core/pull/9593))

## [4.2.3]
Expand Down
1 change: 0 additions & 1 deletion packages/gator-permissions-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const gatorPermissionsController = new GatorPermissionsController({
'native-token-periodic',
Comment thread
jeffsmale90 marked this conversation as resolved.
'erc20-token-stream',
'erc20-token-periodic',
'erc20-token-revocation',
],
// Optional: override the default gator permissions provider Snap id
// gatorPermissionsProviderSnapId: 'npm:@metamask/gator-permissions-snap',
Expand Down
2 changes: 1 addition & 1 deletion packages/gator-permissions-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/7715-permission-types": "^0.7.1",
"@metamask/7715-permission-types": "^1.0.0",
"@metamask/abi-utils": "^2.0.3",
"@metamask/base-controller": "^9.1.0",
"@metamask/delegation-core": "^2.2.1",
Expand Down
Loading