feat(profile-metrics-service): add proof signing system#9016
Open
mathieuartu wants to merge 8 commits into
Open
feat(profile-metrics-service): add proof signing system#9016mathieuartu wants to merge 8 commits into
mathieuartu wants to merge 8 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1844
Checklist
Note
Medium Risk
Introduces cryptographic signing paths through the keyring and silent snap client requests; behavior is well-tested but mistakes could affect account verification or snap trust boundaries.
Overview
Adds
ProofOfOwnershipServiceso profile metrics can attach chain-native ownership proofs toAccountWithScopes.proofbeforeProfileMetricsService:submitMetrics.The messenger action
ProofOfOwnershipService:sign({ account, nonce })picks the signer from the account’s first CAIP scope: EVM usesKeyringController:signPersonalMessageonmetamask:proof-of-ownership:<nonce>:<canonical address>; Solana, Tron, and Bitcoin use silentSnapController:handleRequest(onClientRequest,origin: 'metamask') with JSON-RPCsignProofOfOwnershiponaccount.metadata.snap.id. Unsupported namespaces throwProofUnsupportedNamespaceErrorfor callers to omit proof.Package exports add
ProofOfOwnershipService,proofOfOwnershipServiceName, andprofileMetricsServiceName(alias for the existing metricsserviceName). Dependencies add snaps packages anduuid; controller/service types import from dedicated*-method-action-typesmodules instead of the package barrel.Reviewed by Cursor Bugbot for commit e376a1c. Bugbot is set up for automated code reviews on this repo. Configure here.