fix: held tokens price data#9008
Draft
GeorgeGkas wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ffab58f. Configure here.
| // held tokens (e.g. USDC) produce a fiat value. `normalizeAssetId` checksums | ||
| // EVM ERC-20 references so a lower-cased input matches the stored key. | ||
| const assetPrice = | ||
| assetsPrice?.[normalizeAssetId(assetId)] ?? assetsPrice?.[assetId]; |
There was a problem hiding this comment.
Malformed ERC20 lookup throws
Medium Severity
selectExchangeRateByAssetId now always calls normalizeAssetId before legacy rate paths. For invalid short EVM ERC-20 references, normalizeAssetId checksums via toChecksumAddress, which throws on non–40-character hex. That breaks the prior contract of returning {} without throwing for malformed asset IDs.
Reviewed by Cursor Bugbot for commit ffab58f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Explanation
References
Checklist
Note
Low Risk
Scoped selector change for display and quote metadata pricing; bridge controller rates still take precedence and legacy paths are unchanged when
assetsPriceis absent.Overview
Fixes missing fiat values for held tokens (e.g. USDC) when clients use unified
AssetsControllerpricing viauseAssetsControllerForRates.selectExchangeRateByAssetIdnow looks up fungibleassetsPriceentries (after bridgeassetExchangeRates, before legacymarketData/ currency slices), mappingprice/usdPricetoexchangeRate/usdExchangeRate.normalizeAssetIdaligns lowercased CAIP-19 IDs with checksummed keys; NFT and invalid price rows are skipped. Exchange-rate source types include optionalassetsPrice. Tests and changelog document the behavior.Reviewed by Cursor Bugbot for commit ffab58f. Bugbot is set up for automated code reviews on this repo. Configure here.