chore(skills): use shared skills package#8965
Conversation
There was a problem hiding this comment.
Thanks for adding a focused skills workflow and tests around the cache/postinstall behavior. I am requesting changes because the new root postinstall entry currently breaks the repo’s normal install path: LavaMoat allow-scripts detects the root lifecycle script and exits until $root$ is configured, even though Yarn itself will not execute lifecycle scripts with enableScripts: false.
Please address the install failure by either adding the explicit root allow-scripts policy or moving this cache refresh into an explicitly invoked setup command instead of declaring a root lifecycle script. I verified scripts/skills-postinstall.test.ts passes with coverage disabled, and git diff --check origin/main...HEAD passes.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9969f81. Configure here.
# Conflicts: # .gitignore
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…sion
The previous `if/then/else/fi` guard fails under Yarn 4's portable
shell ("command not found: if"), breaking the install lifecycle in CI.
Match the mobile/extension shared-skills pattern: postinstall delegates
to `yarn skills:postinstall` -> `metamask-skills postinstall`.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Summary
yarn skillsintegration for Core, mirroring Mobile/Extension behavior.@metamask/skillsCLI instead of keeping Core-local sync scripts.Related
Validation
Validated against the published
@metamask/skillsnpm package (^0.1.0):node --check bin/metamask-skills.mjsnpm pack --pack-destination /tmpsync --target /Users/deeeed/dev/metamask/core-4 --dry-runpostinstall --target /Users/deeeed/dev/metamask/core-4 --dry-runwithSKILLS_AUTO_UPDATE=1METAMASK_SKILLS_TARGET_REPO=coreThe lockfile has been refreshed against the published package, so dependency install / immutable install checks now pass.
How to use
Run manual sync:
To opt into best-effort regeneration during setup/install, add this to
.skills.localor your shell:Optional filters work through the shared installer:
Use
METAMASK_SKILLS_TARGET_REPOlocally for forks or unusual remotes that should use the canonicalcoreoverlays.Note
Low Risk
Developer-only tooling and install hooks; no runtime library or controller code changes.
Overview
Wires Core into the shared
@metamask/skillsCLI so agent skills sync matches Mobile/Extension instead of repo-local scripts.package.jsonaddsyarn skills(metamask-skills sync),skills:postinstall, and a rootpostinstallhook (optional refresh whenSKILLS_AUTO_UPDATE=1).@metamask/skills@^0.1.0is a devDependency with an updatedyarn.lock. LavaMoatallowScriptsnow allows$root$so install can run the skills postinstall..gitignoreexcludes.skills.local,.skills-cache/, and generated outputs under.claude/skills/,.agents/skills/, and.cursor/rules/..skills.local.exampledocuments domain filters and env overrides; README adds an Agent skills section with usage commands.Reviewed by Cursor Bugbot for commit 08001cc. Bugbot is set up for automated code reviews on this repo. Configure here.