Add transaction pay quote usability fallback#8581
Draft
pedronfigueiredo wants to merge 1 commit intopnf/bidirectional-fallbackfrom
Draft
Add transaction pay quote usability fallback#8581pedronfigueiredo wants to merge 1 commit intopnf/bidirectional-fallbackfrom
pedronfigueiredo wants to merge 1 commit intopnf/bidirectional-fallbackfrom
Conversation
9992242 to
971e575
Compare
971e575 to
8265af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follow-up keeps the Transaction Pay fallback principle intact after provider quotes are constructed. A strategy can now return technically supported quotes but still be skipped if those quotes are unusable for the current account context, such as when they require origin native gas that the account cannot pay.
The quote loop now checks strategy support, fetches quotes, checks provider quote support, then runs a normalized quote usability check before selecting the strategy. If the first strategy is unusable, the controller logs the reason and continues to the next configured strategy. This lets Across remain first when the account can complete the route, while allowing Relay to win when it can provide a gasless path for the same situation.
Changes
checkQuoteUsabilityto evaluate quote requirements against native source-chain balance.quote-usabilitycoverage for authorization-list, native-source, non-object original quote, invalid amount, and missing amount branches.