Perps/fix available to trade balance core wt#8534
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This change fixes a controller gap in
@metamask/perps-controllerwhere consumers could not distinguish between withdrawable funds and actual trading buying power for HyperLiquid accounts.The controller only exposed
availableBalance, which maps to HyperLiquid withdrawable, so clients using that field for funded state checks could incorrectly treat spot-funded accounts as unfunded even when HyperLiquid shows usable buying power.The improvement is a new
availableToTradeBalancefield on perps account state. For HyperLiquid, it is calculated from perps withdrawable balance plus spot USDC, whileavailableBalanceremains unchanged as the withdrawable only value.The field is populated in both one-shot account fetches and live streamed account updates, and the shared account aggregation path carries it through consistently.
This gives mobile and extension a dedicated funded-state signal without changing existing withdraw behavior or order-entry calculations.
References
Checklist