feat: Add createOriginMiddleware function#8522
Open
FrederikBolding wants to merge 3 commits intomainfrom
Open
Conversation
createOriginMiddlewarecreateOriginMiddleware function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add a
createOriginMiddlewarefunction which adds the origin to theMiddlewareContext, to be leveraged by later middlewares.References
Checklist
Note
Low Risk
Low risk: adds a small new middleware helper and export without changing existing request handling behavior.
Overview
Adds a new
createOriginMiddleware(origin)utility forJsonRpcEngineV2that setscontext.originand then delegates tonext().Exports the helper from
@metamask/json-rpc-engine/v2, adds a unit test to validate context propagation, and updates the package changelog to announce the new API.Reviewed by Cursor Bugbot for commit bacdcef. Bugbot is set up for automated code reviews on this repo. Configure here.