feat(profile-sync-controller): add profile pairing & canonical profile id management#8504
Open
mathieuartu wants to merge 14 commits intomainfrom
Open
feat(profile-sync-controller): add profile pairing & canonical profile id management#8504mathieuartu wants to merge 14 commits intomainfrom
mathieuartu wants to merge 14 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
@metamaskbot publish-preview |
1 similar comment
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
…to ma/auth-profile-pairing
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e849840. Configure here.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
High Risk
Modifies SRP authentication/session behavior and profile identifier handling (including a new server pairing call), which can impact login stability and any storage keyed by profile IDs.
Overview
Adds SRP profile pairing and canonical identity tracking.
AuthenticationController.performSignInnow logs in each SRP and, when 2+ SRPs exist, callsPOST /profile/pair, propagates the returnedcanonicalProfileIdto all cachedsrpSessionDataentries, and emits a newAuthenticationController:profileSignInevent when pairing yields aliases or the canonical changes.Extends the auth SDK to support pairing + alias-aware IDs. The SRP flow now sends
X-MetaMask-Profile-Pairing: enabledon/srp/login, parsesprofile_aliases, keeps the original per-SRPprofileId(for storage derivation) while addingcanonicalProfileId, and forces re-login when cached sessions lack a canonical ID. AddspairProfilesservice/API (/api/v2/profile/pair),pairSrpProfilesmethods on auth classes, a newcomputeIdentifierIdhelper, and expands tests/fixtures/changelog accordingly.Reviewed by Cursor Bugbot for commit a3274bb. Bugbot is set up for automated code reviews on this repo. Configure here.