Skip to content

ci: Drop Node.js 18, run jobs on Node.js 24 #8499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Mrtenz wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −16
Draft

ci: Drop Node.js 18, run jobs on Node.js 24 #8499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fde88cf
Drop Node.js 18, run jobs on Node.js 24
Mrtenz Apr 16, 2026
1814913
Readd missing node-version
Mrtenz Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ensure-blocking-pr-labels-absent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
pull-requests: read
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
- name: Run command
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/lint-build-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [20.x, 22.x, 24.x]
Copy link
Copy Markdown
Member

@FrederikBolding FrederikBolding Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait and drop both 18 and 20 in two weeks? https://endoflife.date/nodejs

outputs:
child-workspace-package-names: ${{ steps.workspace-package-names.outputs.child-workspace-package-names }}
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
cache-node-modules: true
Expand All @@ -31,7 +31,7 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
script:
- lint:eslint
- lint:misc:check
Expand All @@ -42,7 +42,7 @@ jobs:
- readme-content:check
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
Expand All @@ -64,11 +64,11 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
Expand Down Expand Up @@ -97,10 +97,10 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
Expand All @@ -119,10 +119,10 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [22.x]
node-version: [24.x]
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
Expand All @@ -141,11 +141,11 @@ jobs:
needs: prepare
strategy:
matrix:
node-version: [18.x, 20.x, 22.x]
node-version: [20.x, 22.x, 24.x]
package-name: ${{ fromJson(needs.prepare.outputs.child-workspace-package-names) }}
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: false
node-version: ${{ matrix.node-version }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: true
- uses: MetaMask/action-publish-release@v3
Expand All @@ -38,7 +38,7 @@ jobs:
needs: publish-release
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: true
ref: ${{ github.sha }}
Expand All @@ -59,7 +59,7 @@ jobs:
needs: publish-npm-dry-run
steps:
- name: Checkout and setup environment
uses: MetaMask/action-checkout-and-setup@v2
uses: MetaMask/action-checkout-and-setup@v3
with:
is-high-risk-environment: true
ref: ${{ github.sha }}
Expand Down