fix(transaction-pay-controller): allow Across perps ETH gas top-up quotes#8493
Closed
pedronfigueiredo wants to merge 1 commit intomainfrom
Closed
fix(transaction-pay-controller): allow Across perps ETH gas top-up quotes#8493pedronfigueiredo wants to merge 1 commit intomainfrom
pedronfigueiredo wants to merge 1 commit intomainfrom
Conversation
pedronfigueiredo
force-pushed
the
codex/across-perps-eth-top-up
branch
from
3f95738 to
eca412d
Compare
…otes Across perps deposits originating from the PerpsController were being rejected before any quote call when the route included both the USDC deposit leg and the destination-chain ETH gas top-up leg. The existing Across perps support check only allowed the Arbitrum USDC leg, so the ETH leg triggered quotes-strategy-unsupported and the whole route was rejected locally before reaching Across. Widen the perps support gate to allow the native ETH top-up leg while still only normalizing the USDC leg into the HyperCore direct-deposit path. This preserves mixed USDC + ETH perps bundles and adds regression coverage for that route shape.
pedronfigueiredo
force-pushed
the
codex/across-perps-eth-top-up
branch
from
eca412d to
0fb5941
Compare
Contributor
Author
|
Closing in favor of #8527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Across perps deposits originating from the PerpsController were being rejected before any quote call when the route included both the USDC deposit leg and the destination-chain ETH gas top-up leg.
The existing Across perps support check only allowed the Arbitrum USDC leg, so the ETH leg triggered quotes-strategy-unsupported and the whole route was rejected locally before reaching Across.
Widen the perps support gate to allow the native ETH top-up leg while still only normalizing the USDC leg into the HyperCore direct-deposit path. This preserves mixed USDC + ETH perps bundles and adds regression coverage for that route shape.
References
Checklist
Note
Medium Risk
Changes strategy support gating for perps deposit quotes, which could alter which requests are considered eligible for Across quoting. Scope is limited to
perpsDepositon Arbitrum (USDC vs native token) and is covered by new unit tests.Overview
Enables Across quoting for mixed perps deposit bundles by expanding the perps support check to accept both the Arbitrum USDC deposit leg and the Arbitrum native-token (gas top-up) leg.
Keeps normalization to the HyperCore direct-deposit route only for the USDC deposit leg (leaving native-token top-up requests untouched), and adds a focused regression test suite for the new support/normalization behavior. Updates the package changelog to document the fix.
Reviewed by Cursor Bugbot for commit 0fb5941. Bugbot is set up for automated code reviews on this repo. Configure here.