chore: add missing native asset (slip44) icons and metadata - #1898
Merged
Conversation
Cross-references the SPOT_PRICES_SUPPORT_INFO slip44 map in MetaMask Core's codefi-v2.ts against the extension's per-chain native token icons (CHAIN_ID_TOKEN_IMAGE_MAP / CHAIN_ID_TO_NETWORK_IMAGE_URL_MAP in shared/constants/network.ts) to backfill 30 chains whose native asset was missing from this repo. - Chains whose native asset is ETH (slip44:60) reuse the existing generic ETH icon already established for eip155:4326 and eip155:4663. - Chains with a distinct native asset (CRO, RBTC, BNB, VLX, POL, KCS, S, FTM, FLOW, GLMR, MOVR, INJ, CELO, AVAX, ONE) use that asset's icon from metamask-extension's app/images. No existing files were modified or removed.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Tempo Mainnet (eip155:4217) and Tempo Testnet Moderato (eip155:42431) were incorrectly added as native ETH/slip44:60 in the previous commit. Tempo has no native ETH asset — wallets configure its native currency as USD and fees are paid in TIP-20 stablecoins, so the ETH/slip44:60 entry misrepresented the asset. Removing both until there's a correct representation. Also adds Chiliz Chain (eip155:88888), whose native asset (CHZ) is addressed via erc20:0x0000...0000 rather than slip44 in Core's codefi-v2.ts, using the chiliz.svg icon from metamask-extension.
Not part of the slip44 pass — erc20:0x0-addressed native assets are a separate list that wasn't confirmed for inclusion.
xdc-network's native XDC has a slip44 conflict upstream (it collides with another chain's coin_type), so codefi-v2.ts addresses it via erc20:0x0000...0000 rather than a slip44 id. Adding it here under that same convention so the native asset isn't left without an icon. This is a stopgap pending a cleaner long-term representation.
Wrong fix in the previous commit — XDC's coin_type is 550. Swapping eip155:50/erc20:0x0 for eip155:50/slip44:550.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b2d4c1. Configure here.
| bzidztbD9WQOHu19LCer9Ww5AYSa/Qd+An+k/GB/v37ZcP35f6tJ6xw= | ||
| ]]> | ||
| </i:pgf> | ||
| </svg> |
There was a problem hiding this comment.
Illustrator SVG violates style guide
Medium Severity
The new XDC icon is a raw Adobe Illustrator export that includes a forbidden foreignObject, DOCTYPE entity definitions, and roughly 700 lines of proprietary i:pgf CDATA. STYLEGUIDE.md requires pure vector shapes only. Peer icons in this PR are cleaned SVGs; this file is mostly non-rendering junk that can break stricter SVG consumers.
Reviewed by Cursor Bugbot for commit 5b2d4c1. Configure here.
MRabenda
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-references the SPOT_PRICES_SUPPORT_INFO slip44 map in MetaMask Core's codefi-v2.ts against the extension's per-chain native token icons (CHAIN_ID_TOKEN_IMAGE_MAP / CHAIN_ID_TO_NETWORK_IMAGE_URL_MAP in shared/constants/network.ts) to backfill 30 chains whose native asset was missing from this repo.
No existing files were modified or removed.
Note
Low Risk
Additive static assets and JSON metadata only; no application logic, auth, or data pipeline changes.
Overview
Adds 30 new native-asset entries under
icons/eip155:*and matchingmetadata/eip155:*/slip44:*.jsonso spot-price / wallet flows can resolve logos and symbols for chains that were missing from this repo.ETH-native chains (
slip44:60) each get the shared purple ETH circle artwork (same pattern as other ETH L2 entries already in the repo). Non-ETH natives use distinct SVGs: e.g. BNB, POL, AVAX, CRO, FTM, CELO, GLMR, MOVR, VLX, KCS, FLOW, ONE, INJ, RBTC, XDC, and S.Each metadata file sets
name,symbol,decimals: 18,erc20: false, and a relativelogopath. No existing icons or metadata were changed or removed—this is additive backfill only.Reviewed by Cursor Bugbot for commit 5b2d4c1. Bugbot is set up for automated code reviews on this repo. Configure here.