Add MeshSave::toPly overloads for TriMesh#6426
Merged
Merged
Conversation
Implement saving of TriMesh in .ply format (both file and stream variants) sharing the code with Mesh saving via toPlyImpl function template and small accessor helpers, without converting one mesh representation into the other. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Grantim
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two new functions for saving
TriMeshin .ply format:To avoid copy-paste and any conversion between
MeshandTriMesh, the existingtoPlyimplementation is turned into thetoPlyImplfunction template, and the differences between the two representations are factored into small accessor helpers (getVertRenumber,lastValidVert,hasVert,lastValidFace,numValidFaces,hasFace,getTriVerts). All vertices and triangles ofTriMeshare considered valid, so vertex renumbering for it is identity, andSaveSettings::onlyValidPoints/SaveSettings::packPrimitiveshave no effect on it.The saved bytes for
Meshare exactly the same as before (onlymesh.topology.getTriVerts( f, vs )call was replaced with the equivalent by-value overload).New unit test
MRMesh.TriMeshSavePlyverifies that saving aTriMeshproduces byte-identical .ply output to saving the equivalentMesh, and that the output loads back correctly.Local verification: MRTest Release x64 — all 306 tests pass.
🤖 Generated with Claude Code