Check mrbind#38 (forwarding-lambda member binding) is Clang/GCC compatible#6273
Closed
Fedr wants to merge 2 commits into
Closed
Check mrbind#38 (forwarding-lambda member binding) is Clang/GCC compatible#6273Fedr wants to merge 2 commits into
Fedr wants to merge 2 commits into
Conversation
…nding change mrbind#38 changes pybind member functions to bind via a forwarding lambda instead of a static_cast'd pointer-to-member (fixes MSVC C2440 on overloaded auto-returning members of class templates). This PR bumps only the submodule and runs the full matrix to confirm the change does not regress the existing Clang/GCC Python-binding builds. No MSVC-bindings wiring here -- that lives in the separate prototype PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Picks up the mrbind fix for calling template member functions through their full name (with template args), which regressed the Clang bindings build with the first #38 revision. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Full matrix is green — this confirms mrbind#38 (forwarding-lambda member binding + full-name template-member calls) does not regress the Clang/GCC Python-binding builds. Closing: this was a CI compatibility check, not for merge (it pinned a mrbind PR-branch commit). The mrbind#38 change will land via the normal thirdparty/mrbind submodule bump once it merges to mrbind master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Verify that mrbind#38 — which changes pybind member-function binding from a
static_casted pointer-to-member to a forwarding lambda — does not regress the existing Clang / GCC Python-binding builds.mrbind#38 fixes MSVC
C2440on overloaded,auto-returning members of class templates (e.g.MR::Buffer<T,I>::data()); upstream MSVC bug: https://developercommunity.visualstudio.com/t/C2440:-static_cast-to-select-an-overload/11107969 . Since the change touches all member-function bindings (not just the failing ones), this PR runs the full matrix to make sure the previously-working Clang/GCC paths still build and pass.What's in it
thirdparty/mrbindsubmodule bump to the Separate MREmbeddedPython.h from MRPython.h #38 branch HEAD. MeshLib's current pin is the direct parent of mrbind master, so this is effectively "current mrbind + the lambda change" (plus the already-merged-bound mrbind#37 GCC fix).Not for merge as-is
This pins a mrbind PR-branch commit. Once mrbind#38 merges to mrbind master, the real submodule bump should point at the merged master commit. This PR is a CI compatibility check.