fix: log swallowed lazy-import failures to aid diagnosability by praisonai-triage-agent[bot] · Pull Request #2899 · MervinPraison/PraisonAI

praisonai-triage-agent · 2026-07-10T17:16:08Z

Summary

The package-level lazy loader (create_lazy_getattr_with_fallback in praisonaiagents/_lazy.py) swallowed ImportError/AttributeError for any mapped public symbol, returned None, and cached it for the process lifetime. This masked real import bugs and stale _LAZY_IMPORTS mapping entries as confusing TypeError: 'NoneType' object is not callable errors far from the root cause.

Change (purely additive)

Preserve the existing graceful None fallback and its caching — no behaviour/API change.
Log the swallowed exception (name, module path, attr, original error) so failures are diagnosable.
Distinguish the two failure modes:
- ImportError (genuinely-absent optional module) → DEBUG (stays quiet by default).
- AttributeError (module imports but attribute missing → stale/renamed mapping) → WARNING (louder signal).
Logging only fires on the error branch, so there is no import-time or hot-path cost.

Validation

Added ad-hoc test confirming: missing module → None + DEBUG log; stale attribute → None + WARNING log; valid symbol resolves; cached None preserved.
Verified import praisonaiagents still works cleanly.

Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved handling of unavailable or renamed lazy-loaded attributes.
- Prevented lookup failures from interrupting application behavior by safely returning an unavailable value.
Diagnostics
- Added more specific logging for missing attributes and failed imports, making troubleshooting clearer.

…2897) The package-level lazy loader silently converted real ImportError/ AttributeError into a cached None, masking genuine import bugs and stale mapping entries as confusing NoneType errors far from the root cause. This additive change preserves the graceful None fallback but logs the swallowed exception: DEBUG for a genuinely-absent optional module and WARNING for a missing attribute (which usually signals a stale mapping). Co-authored-by: MervinPraison <MervinPraison@users.noreply.github.com>

MervinPraison · 2026-07-10T17:16:19Z

@coderabbitai review

MervinPraison · 2026-07-10T17:16:20Z

/review

qodo-code-review · 2026-07-10T17:16:24Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

coderabbitai · 2026-07-10T17:16:25Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-07-10T17:16:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6d5e70e5-015a-460c-873e-938703a0cc74

📥 Commits

Reviewing files that changed from the base of the PR and between ca6489a and 50097e5.

📒 Files selected for processing (1)

src/praisonai-agents/praisonaiagents/_lazy.py

📝 Walkthrough

Walkthrough

The lazy loader now initializes a module logger and distinguishes AttributeError from ImportError, logging each failure type while retaining the existing cached None fallback.

Changes

Lazy loader diagnostics

Layer / File(s)	Summary
Lazy import failure logging `src/praisonai-agents/praisonaiagents/_lazy.py`	Adds module-level logging, warns about potentially stale attribute mappings, and debug-logs import failures while preserving cached `None` results.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: MervinPraison

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding logs for swallowed lazy-import failures.
Linked Issues check	✅ Passed	The PR preserves cached None fallback and adds distinct logging for ImportError and AttributeError as requested by `#2897`.
Out of Scope Changes check	✅ Passed	The changes stay focused on _lazy.py and do not introduce unrelated modifications.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/issue-2897-20260710-1714

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps · 2026-07-10T17:17:30Z

Greptile Summary

This PR adds diagnostics for swallowed lazy-import failures. The main changes are:

Adds a module logger in praisonaiagents._lazy.
Logs missing lazy-import attributes as warnings.
Logs missing optional lazy-import modules as debug messages.
Keeps the existing cached None fallback behavior.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.
The logging runs after the lazy import failure is caught and keeps the previous None fallback.
The added logger uses standard library logging and does not change the import cache contract.

Important Files Changed

Filename	Overview
src/praisonai-agents/praisonaiagents/_lazy.py	Adds logging to the lazy-loader fallback branches without changing the existing return or cache behavior.

_{Reviews (1): Last reviewed commit: "fix: log swallowed lazy-import failures ..." | Re-trigger Greptile}

MervinPraison · 2026-07-10T17:17:41Z

@claude You are the FINAL architecture reviewer. If the branch is under MervinPraison/PraisonAI (not a fork), you are able to make modifications to this branch and push directly. SCOPE: Focus ONLY on Python packages (praisonaiagents, praisonai). Do NOT modify praisonai-rust or praisonai-ts. Read ALL comments above from Gemini, Qodo, CodeRabbit, and Copilot carefully before responding.

Phase 1: Review per AGENTS.md

Protocol-driven: check heavy implementations vs core SDK
Backward compatible: ensure zero feature regressions
Performance: no hot-path regressions
SDK value: review in depth whether the change genuinely adds value to the SDK — never add features for the sake of adding them. It must strengthen the SDK (simpler, more user-friendly, robust, world-class, secure). If it does not clearly add value, request changes or recommend rejecting/closing rather than merging scope creep
Do not bloat the Agent class with additional params — only if absolutely required; we already support many params.
Repo routing: agent-callable tools → PraisonAI-Tools; lifecycle plugins → PraisonAI-Plugins; optional sandbox backends → PraisonAI-Plugins (praisonai.sandbox entry point) — request changes if wrongly added to praisonaiagents/

Phase 2: FIX Valid Issues
7. For any VALID bugs or architectural flaws found by Gemini, CodeRabbit, Qodo, Copilot, or any other reviewer: implement the fix
8. Push all code fixes directly to THIS branch (do NOT create a new PR)
9. Comment a summary of exact files modified and what you skipped

Phase 3: Final Verdict
10. If all issues are resolved, approve the PR / close the Issue
11. If blocking issues remain, request changes / leave clear action items

praisonai-triage-agent · 2026-07-10T17:18:06Z

Claude finished @MervinPraison's task —— View job

Final Architecture Review — PR #2899 ✅ Approve

Read AGENTS.md guidelines
Review changed file _lazy.py
Validate architecture (routing, backward-compat, performance, SDK value)
Check reviewer feedback for valid issues
Fix any valid issues + push
Final verdict

Scope: Single file src/praisonai-agents/praisonaiagents/_lazy.py (+23/-2). Python-only, in-scope. No praisonai-rust/praisonai-ts touched.

Phase 1 — AGENTS.md checks

Check	Result
Protocol-driven / core placement	✅ Diagnostics logging in an internal helper — correct layer, not a heavy impl
Backward compatible	✅ Graceful `None` fallback + caching preserved; no API/behaviour change
Performance (hot path)	✅ Logging fires only on the exception branch; zero cost on cache-hit / success path
SDK value	✅ Real value: converts confusing `NoneType is not callable` failures into diagnosable logs; sensibly splits `ImportError`→DEBUG (quiet) vs `AttributeError`→WARNING (loud, stale-mapping signal)
Agent class bloat	✅ N/A — no Agent params added
Repo routing	✅ Correct repo; not a tool/plugin/sandbox concern

Phase 2 — Reviewer feedback

Greptile: 5/5, safe to merge — no blocking issues.
CodeRabbit: processing; walkthrough only, no actionable findings.
Qodo: reviews paused (account/plan), no findings.

No valid bugs or architectural flaws raised. One minor note (non-blocking): the lazy_import docstring mentions ModuleNotFoundError; since it's a subclass of ImportError, the new except ImportError correctly covers it — behaviour is sound.

Validation (run locally)

import praisonaiagents → OK (clean).
Missing module → None + DEBUG log ✅
Stale attribute → None + WARNING log ✅ (verified emitted)
Valid symbol → resolves correctly ✅
Exception ordering (AttributeError before ImportError) is correct; neither subclasses the other.

Phase 3 — Verdict

Approve. Purely additive, backward-compatible diagnostics that strengthen the SDK's debuggability with no hot-path cost. No changes needed — nothing pushed.
· Branch: claude/issue-2897-20260710-1714

praisonai-triage-agent Bot mentioned this pull request Jul 10, 2026

Core SDK: lazy loader silently masks real import failures as None (and caches them permanently) #2897

Open

MervinPraison added pipeline/blocked:ci Blocked: CI not green on HEAD pipeline/blocked:manual-review Blocked: requires manual review pipeline/blocked:no-final Blocked: no FINAL @claude trigger yet pipeline/final-claude-pending Reviews done; waiting for FINAL @claude labels Jul 10, 2026

praisonai-triage-agent Bot removed pipeline/blocked:ci Blocked: CI not green on HEAD pipeline/blocked:cooldown Blocked: post-push or @claude cooldown labels Jul 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: log swallowed lazy-import failures to aid diagnosability#2899

fix: log swallowed lazy-import failures to aid diagnosability#2899
praisonai-triage-agent[bot] wants to merge 1 commit into
mainfrom
claude/issue-2897-20260710-1714

praisonai-triage-agent Bot commented Jul 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

qodo-code-review Bot commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

greptile-apps Bot commented Jul 10, 2026

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

praisonai-triage-agent Bot commented Jul 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

praisonai-triage-agent Bot commented Jul 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change (purely additive)

Validation

Summary by CodeRabbit

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

qodo-code-review Bot commented Jul 10, 2026

Qodo reviews are paused for this user.

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

greptile-apps Bot commented Jul 10, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

MervinPraison commented Jul 10, 2026

Uh oh!

praisonai-triage-agent Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Final Architecture Review — PR #2899 ✅ Approve

Phase 1 — AGENTS.md checks

Phase 2 — Reviewer feedback

Validation (run locally)

Phase 3 — Verdict

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

praisonai-triage-agent Bot commented Jul 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading

praisonai-triage-agent Bot commented Jul 10, 2026 •

edited

Loading