Support for whitelisting extensions/mimetype#643
Merged
Conversation
Coverage Report for CI Build 28594330861Coverage increased (+0.01%) to 92.17%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
Jun 25, 2026
|
|
||
| #BLACKLIST='.mergin/, .DS_Store, .directory' # cast=Csv() | ||
|
|
||
| # extra file types to permit beyond the default block-list (e.g. scripts) |
Collaborator
There was a problem hiding this comment.
I think give there just empty value without cast.
| if check_skip_validation(filepath): | ||
| return True | ||
| ext = os.path.splitext(filepath)[1].lower() | ||
| if ext in {e.lower() for e in Configuration.UPLOAD_EXTENSIONS_WHITELIST}: |
Collaborator
There was a problem hiding this comment.
I think we can use check_skip_validation function for that job to unify with files or?
varmar05
approved these changes
Jul 1, 2026
… mimetype check -> mime_type config var is not needed
MarcelGeo
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #573
Since #370, the server rejects "dangerous" file types (e.g. .py, .sh) on upload - but self-hosted deployments that legitimately distribute scripts alongside QGIS projects had no way to opt out.
This adds an optional, comma-separated config var to bypass file security checks:
UPLOAD_EXTENSIONS_WHITELIST- extra file extensions to permit, e.g. .py, .sh