Skip to content

Do not log xml error responses #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcelGeo merged 1 commit into from
May 13, 2026
Merged

Do not log xml error responses #624

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions server/mergin/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,13 +389,16 @@ def handle_exception(e):
def log_bad_request(response):
"""Log bad requests for easier debugging"""
if response.status_code == 400:
json_body = response.get_json(silent=True)
if json_body and json_body.get("detail"):
# default response from connexion (check against swagger.yaml)
logging.warning(f'HTTP 400: {json_body["detail"]}')
if "xml" in response.content_type:
pass # QGIS proxy errors are already logged at the source
else:
# either WTF form validation error or custom validation with abort(400)
logging.warning(f"HTTP 400: {response.data}")
json_body = response.get_json(silent=True)
if json_body and json_body.get("detail"):
# default response from connexion (check against swagger.yaml)
logging.warning(f'HTTP 400: {json_body["detail"]}')
else:
# either WTF form validation error or custom validation with abort(400)
logging.warning(f"HTTP 400: {response.data}")
elif response.status_code == 409:
# request which would result in conflict, e.g. creating the same project again
logging.warning(f"HTTP 409: {response.data}")
Expand Down
Loading