Skip to content

Fix antenna height value sometimes showing floating point noise #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Withalion wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix antenna height value sometimes showing floating point noise #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/appsettings.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,10 @@ void AppSettings::setGpsAntennaHeight( const double gpsAntennaHeight )
}
if ( mGpsAntennaHeight != height )
{
mGpsAntennaHeight = gpsAntennaHeight;
mGpsAntennaHeight = height;
setValue( "gpsHeight", height );

emit gpsAntennaHeightChanged( gpsAntennaHeight );
emit gpsAntennaHeightChanged( height );
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/qml/settings/MMSettingsPage.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ MMPage {
title: qsTr("GPS antenna height")
description: qsTr("Includes pole height and GPS receiver’s antenna height")
valueDescription: qsTr("GPS antenna height, in meters")
value: AppSettings.gpsAntennaHeight
value: __inputUtils.formatNumber(AppSettings.gpsAntennaHeight, 3)
suffix: " m"

onValueWasChanged: function( newValue ) {
Expand Down
Loading