tmp: center sidebar logo + bump size#11345
Closed
jd wants to merge 2 commits intodevs/jd/worktree-design/redesign-navbar-light-mode-readability--16005d31from
Closed
Conversation
The post-token-migration navbar used a gray-50 body bg under a 95% opacity blurred header — readable in dark mode (where navbar bg matched body bg by design) but with insufficient contrast in light mode for the nav links to read against scrolling content. - Map --theme-navbar-bg to --theme-bg-content (white in light). Dark mode is unaffected since --theme-bg-content aliases --theme-bg there. - Drop the color-mix transparency and backdrop-filter blur in Header.astro. The navbar is a solid surface; a soft 1px shadow conveys lift without the hard line a bottom border would draw. - Remove the radial-gradient ::after scoop on the left sidebar in BaseLayout.astro. With the new white navbar, the scoop is between two same-color surfaces and serves no visual purpose. Change-Id: I16005d31ebd4ba2e7d6fa10395fe2b7ad1819bc7
Change-Id: I7d8669709042eca22ffbf5dff62bb997917cd5f6
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Apr 30, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 Enforce conventional commitWaiting for:
This rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🔴 📕 PR descriptionWaiting for:
This rule is failing.
🟠 🤖 Continuous IntegrationWaiting for:
Waiting checks:
|
jd
force-pushed
the
devs/jd/worktree-design/redesign-navbar-light-mode-readability--16005d31
branch
from
24c6225 to
8c4bd99
Compare
jd
deleted the
devs/jd/worktree-design/center-sidebar-logo-bump-size--7d866970
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-On: #11336