Skip to content

improve ing #14#1

Merged
Maxr1998 merged 2 commits intoMaxr1998:masterfrom
meigelb:pr14
Apr 6, 2026
Merged

improve ing #14#1
Maxr1998 merged 2 commits intoMaxr1998:masterfrom
meigelb:pr14

Conversation

@meigelb
Copy link
Copy Markdown

@meigelb meigelb commented Mar 22, 2026

address review findings of faiteanu#14 (comment)

  • configure only valid periods and exchanges for current isin
  • add some logs to debug error conditions
  • offer sync of ohlc (open/high/low/close)
  • make robust against order of ohlc data by mapping keys to their corresponding values

Copy link
Copy Markdown
Owner

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but the code changes look good. Thanks for handling it!

@Maxr1998 Maxr1998 merged commit c1fc3fa into Maxr1998:master Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants