Skip to content

Restored animations#8

Open
jarmo wants to merge 3 commits into
MathiasWP:masterfrom
jarmo:restored-animations
Open

Restored animations#8
jarmo wants to merge 3 commits into
MathiasWP:masterfrom
jarmo:restored-animations

Conversation

@jarmo
Copy link
Copy Markdown

@jarmo jarmo commented Mar 27, 2022

Restore previously removed animations when changing months

@MathiasWP
Copy link
Copy Markdown
Owner

Things to consider:

  • Should animations be toggle-able?
  • What about users that prefer reduced motion

@jarmo
Copy link
Copy Markdown
Author

jarmo commented Jun 20, 2022

I actually commented here under the commit, which removed animations: 5d07843#comments

Did you get some user feedback and that's why you removed these in the first place?

@jarmo
Copy link
Copy Markdown
Author

jarmo commented Jun 20, 2022

I'd say that animations make things look better and a lot is animated in websphere. Just by adding configurability to this library doesn't change anything in global space.

However, when animations need to be disabled then it is easy to do it via the following CSS:

#calendar-grid.swoosh-up,
#calendar-grid.swoosh-up-reverse,
#calendar-grid.swoosh-down,
#calendar-grid.swoosh-down-reverse {
    animation: none !important;
}

No need to add any extra complexity to this library's codebase to turn animations off.

@jarmo
Copy link
Copy Markdown
Author

jarmo commented Jun 21, 2022

@MathiasWP Just found out about this CSS feature called prefers-reduced-motion: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion

Implemented your requested change - user can now toggle animation via global system setting. I also tested it in Firefox as is mentioned in the documentation above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants