Skip to content

<chore>[sdk]: Update sdk#4300

Open
ZStack-Robot wants to merge 1 commit into
5.4.2-rcloudfrom
sync/haoyu.ding/fix-ZSTAC-86115@@2
Open

<chore>[sdk]: Update sdk#4300
ZStack-Robot wants to merge 1 commit into
5.4.2-rcloudfrom
sync/haoyu.ding/fix-ZSTAC-86115@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Resolves: ZSTAC-86115

Change-Id: I11dc40f4649041f5bb7a7efe5acfa90483950bde

sync from gitlab !10257

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@MatheMatrix, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 24 minutes and 10 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e5d72789-1f01-40f1-948e-9d685818066f

📥 Commits

Reviewing files that changed from the base of the PR and between abe72c9 and 8aa0176.

📒 Files selected for processing (1)
  • sdk/src/main/java/org/zstack/sdk/GenerateModelMetadataAction.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

GenerateModelMetadataAction.java 中,将 Result 内部类的 value 字段类型及 makeResult 方法中的结果解析逻辑,从错误的 DeployModelServiceResult 统一更正为 GenerateModelMetadataResult。共修改 3 行。

Changes

GenerateModelMetadataAction 结果类型修正

Layer / File(s) Summary
Result 字段与 makeResult 方法类型更正
sdk/src/main/java/org/zstack/sdk/GenerateModelMetadataAction.java
Result.value 字段声明由 DeployModelServiceResult 改为 GenerateModelMetadataResultmakeResult 中对应的类型获取及空对象构造也同步替换为 GenerateModelMetadataResult

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 兔子跳跳检查代码,
发现名字写错了哦~
DeployModel 换成 GenerateMeta
类型匹配终于对上啦!
一行修正,万事大吉 🎉

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive 标题过于宽泛且缺乏具体性,使用了"Update sdk"这样的模糊表述,未能清楚表达主要变更内容。 建议将标题改为更具体的描述,例如"[sdk]: Update GenerateModelMetadataAction result type",以更清楚地说明变更的具体内容。
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed 描述与变更集相关,提供了问题追踪编号和来源信息,虽然不包含详细的技术细节,但足以说明这是一个同步更新。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/haoyu.ding/fix-ZSTAC-86115@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

Resolves: ZSTAC-86115

Change-Id: I11dc40f4649041f5bb7a7efe5acfa90483950bde
@MatheMatrix MatheMatrix force-pushed the sync/haoyu.ding/fix-ZSTAC-86115@@2 branch from abe72c9 to 8aa0176 Compare June 18, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants