<fix>[volume]: ZSV-12438 support encrypted data volume creation#4271
Conversation
|
Warning Review limit reached
More reviews will be available in 45 minutes and 53 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
195a993 to
ac265bf
Compare
Resolves: ZSV-12438 Change-Id: I68667a6a776e617866746673697475787a6b6467
ac265bf to
1eb69ef
Compare
Summary: expose encrypted parameter on CreateDataVolume and CreateDataVolumeFromVolumeTemplate API/SDK messages; propagate encrypted flag into internal volume creation and persist it; add unit coverage. Test: deployed jars to 172.26.213.50; SDK CreateDataVolumeAction(encrypted=True) created encrypted=True volume; SDK CreateDataVolumeFromVolumeTemplateAction(encrypted=True) created Ready encrypted=True volume on sblk; with keyProvider/default.keyProviderUuid=None both SDK calls failed with default key provider is not configured and config was restored. Jira: http://jira.zstack.io/browse/ZSV-12438
sync from gitlab !10229