Skip to content

<fix>[volume]: ZSV-12438 support encrypted data volume creation#4271

Open
ZStack-Robot wants to merge 1 commit into
feature-zsv-5.1.0-encryptionfrom
sync/zstackio/codex/ZSV-12438-encryption-data-volume-sdk@@2
Open

<fix>[volume]: ZSV-12438 support encrypted data volume creation#4271
ZStack-Robot wants to merge 1 commit into
feature-zsv-5.1.0-encryptionfrom
sync/zstackio/codex/ZSV-12438-encryption-data-volume-sdk@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary: expose encrypted parameter on CreateDataVolume and CreateDataVolumeFromVolumeTemplate API/SDK messages; propagate encrypted flag into internal volume creation and persist it; add unit coverage. Test: deployed jars to 172.26.213.50; SDK CreateDataVolumeAction(encrypted=True) created encrypted=True volume; SDK CreateDataVolumeFromVolumeTemplateAction(encrypted=True) created Ready encrypted=True volume on sblk; with keyProvider/default.keyProviderUuid=None both SDK calls failed with default key provider is not configured and config was restored. Jira: http://jira.zstack.io/browse/ZSV-12438

sync from gitlab !10229

@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@MatheMatrix, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 53 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 0cae0cdb-d83b-418d-b04e-c3647ffd87d2

📥 Commits

Reviewing files that changed from the base of the PR and between 4aa0dad and 1eb69ef.

📒 Files selected for processing (10)
  • header/src/main/java/org/zstack/header/volume/APICreateDataVolumeFromVolumeTemplateMsg.java
  • header/src/main/java/org/zstack/header/volume/APICreateDataVolumeFromVolumeTemplateMsgDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/volume/APICreateDataVolumeMsg.java
  • header/src/main/java/org/zstack/header/volume/APICreateDataVolumeMsgDoc_zh_cn.groovy
  • header/src/main/java/org/zstack/header/volume/CreateDataVolumeFromVolumeTemplateMsg.java
  • header/src/main/java/org/zstack/header/volume/CreateDataVolumeMsg.java
  • sdk/src/main/java/org/zstack/sdk/CreateDataVolumeAction.java
  • sdk/src/main/java/org/zstack/sdk/CreateDataVolumeFromVolumeTemplateAction.java
  • storage/src/main/java/org/zstack/storage/volume/VolumeManagerImpl.java
  • test/src/test/java/org/zstack/test/unittest/storage/volume/EncryptedDataVolumeCreateApiTest.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zstackio/codex/ZSV-12438-encryption-data-volume-sdk@@2

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix MatheMatrix force-pushed the sync/zstackio/codex/ZSV-12438-encryption-data-volume-sdk@@2 branch 2 times, most recently from 195a993 to ac265bf Compare June 15, 2026 13:43
Resolves: ZSV-12438

Change-Id: I68667a6a776e617866746673697475787a6b6467
@MatheMatrix MatheMatrix force-pushed the sync/zstackio/codex/ZSV-12438-encryption-data-volume-sdk@@2 branch from ac265bf to 1eb69ef Compare June 15, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant