Skip to content

[4.8.38][ZSTAC-85986] cherry-pick ZSTAC-61889#4263

Open
zstack-robot-2 wants to merge 1 commit into
4.8.38from
sync/shan.wu/fix/4.8.38/ZSTAC-85986
Open

[4.8.38][ZSTAC-85986] cherry-pick ZSTAC-61889#4263
zstack-robot-2 wants to merge 1 commit into
4.8.38from
sync/shan.wu/fix/4.8.38/ZSTAC-85986

Conversation

@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Cherry-pick 5.x merged source fix ZSTAC-61889 into 4.8.38 for ZSTAC-85986.

sync from gitlab !10221

Keep snapshot DB records when the hypervisor snapshot succeeds

but later control-plane flow fails.

KVMHost and VolumeSnapshotManagerImpl now share

syncVolumeSnapshotDBAfterTakeSnapshot for the DB update.

The regression case injects failure after data-plane success

through VolumeSnapshotCreationExtensionPoint.

Resolves: ZSTAC-61889

Change-Id: Ida2ef0ad95e7a2faf4d8db705d97b8807586802d
(cherry picked from commit e009499)
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zstack-robot-2, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour, 35 minutes, and 49 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e6e3cedd-7865-4122-a055-957371b43702

📥 Commits

Reviewing files that changed from the base of the PR and between 752b8b5 and e9afead.

⛔ Files ignored due to path filters (1)
  • conf/springConfigXml/volumeSnapshot.xml is excluded by !**/*.xml
📒 Files selected for processing (4)
  • header/src/main/java/org/zstack/header/storage/snapshot/VolumeSnapshotDBSyncExtensionPoint.java
  • plugin/kvm/src/main/java/org/zstack/kvm/KVMHost.java
  • storage/src/main/java/org/zstack/storage/snapshot/VolumeSnapshotManagerImpl.java
  • test/src/test/groovy/org/zstack/test/integration/storage/snapshot/CreateSnapshotRollbackAfterDataPlaneSuccessCase.groovy
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/shan.wu/fix/4.8.38/ZSTAC-85986

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant