sqllogictest: Cover mz_mcp_data_products view semantics#37636
Draft
bobbyiliev wants to merge 1 commit into
Draft
sqllogictest: Cover mz_mcp_data_products view semantics#37636bobbyiliev wants to merge 1 commit into
bobbyiliev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sqllogictest coverage for the
mz_mcp_data_productsandmz_mcp_data_product_detailsview logic, which previously only had privilege-filtering tests. Covers inclusion rules (materialized vs indexed vs non-indexed views), multi-index dedup, description precedence (index comment over object comment), the JSON Schema column-type mapping, and column comments. Skips cluster-USAGE (covered by the open DEX-66 PR) and hydration counts (replica-timing dependent); 145/145 queries pass.