Skip to content

Fix issue where SHOW CREATE SINK returns a version which can not be used to create a new sink#36798

Open
peterdukelarsen wants to merge 2 commits into
MaterializeInc:mainfrom
peterdukelarsen:pl/scrub-internal-details-from-show-sink
Open

Fix issue where SHOW CREATE SINK returns a version which can not be used to create a new sink#36798
peterdukelarsen wants to merge 2 commits into
MaterializeInc:mainfrom
peterdukelarsen:pl/scrub-internal-details-from-show-sink

Conversation

@peterdukelarsen
Copy link
Copy Markdown
Contributor

Motivation

Closes https://linear.app/materializeinc/issue/SS-160/show-create-sink-includes-internal-version-n-round-trip-fails

Description

Scrubs the version output by SHOW CREATE SINK. Test simply asserts the version isn't output

Verification

  1. I confirmed locally that the round trip with the internal version fails as described in the ticket.
  2. I wrote the fix/test to scrub the version.
  3. I ran the test against the old version of the code locally to confirm it would have failed before.

@peterdukelarsen peterdukelarsen requested a review from a team as a code owner May 29, 2026 20:03
Copy link
Copy Markdown
Contributor

@patrickwwbutler patrickwwbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! congrats on first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants