#1631: ColorPicker doesn't triger color Change event after color chan…#4075
Open
SafuanA wants to merge 1 commit into
Open
#1631: ColorPicker doesn't triger color Change event after color chan…#4075SafuanA wants to merge 1 commit into
SafuanA wants to merge 1 commit into
Conversation
…ent after color change from UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1631: Raise ColorChanged event when ColorPicker color changes from UI
The ColorChanged routed event was not raised when the color was changed through the UI (for example via the HSB controls) because the ColorPropertyChangedCallback returned early while synchronizing the Color and Hsb dependency properties.
This change keeps the recursion guard for the Color/Hsb synchronization but ensures that the ColorChanged event is raised when the Color dependency property value actually changes.
Added a regression test covering UI-driven color changes.