fix: support non-string values in Case When/Then/Else clauses#398
Open
Yanhu007 wants to merge 1 commit intoMasterminds:masterfrom
Open
fix: support non-string values in Case When/Then/Else clauses#398Yanhu007 wants to merge 1 commit intoMasterminds:masterfrom
Yanhu007 wants to merge 1 commit intoMasterminds:masterfrom
Conversation
Previously, passing non-string, non-Sqlizer values (e.g., integers)
to Case().When() or .Else() produced an error:
"expected string or Sqlizer, not int"
This made it impossible to use CASE expressions with numeric values
like:
sq.Case("order_no").When("ORD001", 500).Else(0)
Now non-string, non-Sqlizer values are treated as parameterized
values (using "?" placeholder), consistent with how other parts of
squirrel handle arbitrary values.
Fixes Masterminds#388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388
Problem
Passing non-string, non-Sqlizer values (like integers) to
Case().When()or.Else()fails with:This makes it impossible to use CASE WHEN with numeric values:
Fix
In
part.ToSql(), treat non-string, non-Sqlizer values as parameterized arguments (using?placeholder) instead of returning an error. This is consistent with how other parts of squirrel handle arbitrary values.Before:
"expected string or Sqlizer, not int"errorAfter:
CASE order_no WHEN 'ORD001' THEN ? ELSE ? ENDwith args[500, 0]All existing tests pass.