Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(seo): consolidate spec language overview into hub with ?language= filter #5297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
refactor(seo): consolidate spec language overview into hub with ?language= filter #5297
Changes from all commits
25103943622d04File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint’s behavior changed from serving HTML to returning a permanent 301. There’s currently no unit test asserting the redirect status code and
Locationheader (and that the language segment is intentionally dropped). Adding a test forGET /seo-proxy/{spec}/{language}would prevent regressions and ensure crawlers get the expected consolidation behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hub mode this calls
trackPageviewwith a?language=query string.useAnalytics().trackPageviewcurrently validatesurlOverridewith/^\/([\w\-/])*$/(no?,=), so this override will be rejected and the pageview won’t be tracked whenlanguageFilteris set. Consider either (a) encoding the filter into a path-only override that matches the allowed charset, or (b) not overriding and extending the analytics URL builder to incorporatelanguagesafely.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.