Pw batteries stock node - #5074
Merged
Merged
Conversation
aaltat
force-pushed
the
pw_batteries_stock_node
branch
16 times, most recently
from
July 30, 2026 10:27
b3fb38d to
058965b
Compare
Assemble the BrowserBatteries payload the way Playwright builds its own Python, Java and .NET drivers: the official NodeJS binary from nodejs.org, checksum verified against SHASUMS256.txt, next to the wrapper sources and their production dependencies. Playwright is written and tested against ordinary NodeJS. Packing it into a single file with @yao-pkg/pkg meant inheriting a NodeJS built without the inspector, a snapshot filesystem, and static require analysis that cannot see paths Playwright computes at run time. Each Playwright release risked landing outside that subset, which is what 1.62.0 did twice over. Running the real thing removes the whole category, so the inspector shim and the fork bootstrap it needed are deleted here rather than carried forward. Also drops @yao-pkg/pkg and its now dead config, lets ROBOT_FRAMEWORK_BROWSER_NODE_DEBUG_OPTIONS work under BrowserBatteries, and builds the BrowserBatteries wheel on every release target in on-push.yml, reporting each wheel's size so the packaging trade can be compared against the PyPI file size limit.
Refactor spawn_node_process to work without BrowserBatteries and stop setting the PLAYWRIGHT_BROWSERS_PATH to 0 in all cases
aaltat
force-pushed
the
pw_batteries_stock_node
branch
from
July 31, 2026 10:45
058965b to
d1a2edb
Compare
aaltat
force-pushed
the
pw_batteries_stock_node
branch
from
July 31, 2026 16:21
dfcd971 to
e3d371c
Compare
aaltat
force-pushed
the
pw_batteries_stock_node
branch
from
July 31, 2026 17:13
f88fcdb to
f7cd9d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5073 #5078 #5081 #5082