TICKET-637: Set course dates from term on LTI course creation - #8057
Open
Naragod wants to merge 3 commits into
Open
TICKET-637: Set course dates from term on LTI course creation#8057Naragod wants to merge 3 commits into
Naragod wants to merge 3 commits into
Conversation
Collaborator
Coverage Report for CI Build 30309862827Coverage increased (+0.03%) to 90.497%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Contributor
|
Looks good! Please update branch and I will approve. Thank you. |
donny-wong
force-pushed
the
TICKET-637_auto_course_dates
branch
from
July 23, 2026 19:05
8d2ca66 to
551eecf
Compare
donny-wong
approved these changes
Jul 23, 2026
Contributor
|
@Naragod and @david-yz-liu, I noticed that when a course is created via LTI with the term "2026 Fall-Winter", MarkUs sets the course dates to Sept 1 – Dec 31. The same happens for full-year (Y) courses, e.g. LSM999Y1-Y-LEC0101-20269 in the SIS ID. Shouldn't these span Sept 1 – Apr 30? Or does a MarkUs course only cover a single term? |
Collaborator
|
@donny-wong you're right, for year-long courses it should go Sept 1 - April 30 |
Naragod
force-pushed
the
TICKET-637_auto_course_dates
branch
from
July 27, 2026 22:12
551eecf to
05dee9f
Compare
Contributor
Author
Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes - ✨ New feature
Courses created through the Canvas LTI flow now start with term dates filled in. Before this change, instructors set both dates by hand after every course creation.
LtiConfig.get_course_datesturns the term into a four-month window. "Fall 2025" becomes Sep 1 to Dec 31, 2025.LSM999Y1-Y-LEC0101-20259) wins over the term name when both are present.term_namecustom claim.get_course_dateskeep working through arespond_to?guard.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)