Skip to content

Fix Gtid_log_event::is_part_of_group() #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ParadoxV5 wants to merge 1 commit into
base: 10.11
Choose a base branch
from
Draft

Fix Gtid_log_event::is_part_of_group() #5377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sql/log_event.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3777,6 +3777,9 @@ class Gtid_log_event: public Log_event
enum enum_binlog_checksum_alg checksum_alg,
uint32 *domain_id, uint32 *server_id, uint64 *seq_no,
uchar *flags2, const Format_description_log_event *fdev);
#ifdef HAVE_REPLICATION
bool is_part_of_group() override { return true; }
#endif
Comment on lines +3780 to +3782

@gemini-code-assist gemini-code-assist Bot Jul 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The nested #ifdef HAVE_REPLICATION preprocessor guard is redundant because this block is already enclosed within an outer #ifdef HAVE_REPLICATION block (which ends on line 3783). Removing the redundant guard simplifies the code and improves readability.

  bool is_part_of_group() override { return true; }

@ParadoxV5 ParadoxV5 Jul 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The outer #ifdef block is MYSQL_SERVER.

#endif
};

Expand Down