MDEV-40270 @@default_master_connection does not convert character sets#5350
Open
ParadoxV5 wants to merge 1 commit into
Open
MDEV-40270 @@default_master_connection does not convert character sets#5350ParadoxV5 wants to merge 1 commit into
ParadoxV5 wants to merge 1 commit into
Conversation
`Item::val_str()` doesn’t specify the collation of the returned string, yet `Sys_var_session_lexstring::do_check()` (for `@@default_master_connection`) and `Sys_var_debug_sync::do_check()` (for `@@debug_sync`) assume the `@@character_set_system` collation. This commit replaces `Sys_var_debug_sync::do_check()` with a delegate to `Sys_var_charptr::do_string_check()` to match `Sys_var_dbug::do_check()`, as neither of those has this bug. It ports the character set conversion to `Sys_var_session_lexstring::do_check()` rather than delegating, so the length check is not after a memory allocation; this class has been refactored away in 11.3 (Commit 6151bde) anyway.
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Item::val_str()doesn’t specify the collation of the returned string, yetSys_var_session_lexstring::do_check()(for@@default_master_connection) andSys_var_debug_sync::do_check()(for@@debug_sync) assume the@@character_set_systemcollation.This commit replaces
Sys_var_debug_sync::do_check()with a delegate toSys_var_charptr::do_string_check()to matchSys_var_dbug::do_check(), as neither of those has this bug.It ports the character set conversion to
Sys_var_session_lexstring::do_check()rather than delegating, so the length check is not after a memory allocation; this class has been refactored away in 11.3 (Commit 6151bde) anyway.