-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
MDEV-39708 SBOM contains wrong or missing supplier name for connector-c and libmarias3 #5155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+412
−198
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
666ff1d
MDEV-39519 Change mariadb-dump to use SHOW REPLICA STATUS instead of …
montywi 7694ab3
Fixed that max_session_mem_used.test works for valgrind builds
montywi 8e1945b
Removed compiler warnings about not used/set not used variables in gr…
montywi 5bd29cf
MDEV-33853 fixup: Clarify some API comments
dr-m ac8b775
bump the VERSION
dbart b494164
Merge branch '11.8' into 11.8 release
sanja-byelkin 241050c
MDEV-21423 - lock-free trx_sys get performance regression cause by lf…
svoj 32218f3
bump the VERSION
dbart fa4f6a6
MDEV-39600 Reduce contention in buf_flush_ahead()
iMineLink 33d0ab0
MDEV-39789 Fix compiling without perfschema
mariadb-YuchenPei 457a3d4
MDEV-39708 invalid supplier name for MariaDB's own components
vaintroub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| MYSQL_VERSION_MAJOR=11 | ||
| MYSQL_VERSION_MINOR=8 | ||
| MYSQL_VERSION_PATCH=7 | ||
| MYSQL_VERSION_PATCH=9 | ||
| SERVER_MATURITY=stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ | |
| */ | ||
|
|
||
| /* on merge conflict, bump to a higher version again */ | ||
| #define VER "10.19" | ||
| #define VER "10.20" | ||
|
|
||
| /** | ||
| First mysql version supporting sequences. | ||
|
|
@@ -1428,7 +1428,6 @@ static void DB_error(MYSQL *mysql_arg, const char *when) | |
| } | ||
|
|
||
|
|
||
|
|
||
| /* | ||
| Prints out an error message and kills the process. | ||
|
|
||
|
|
@@ -1491,7 +1490,6 @@ static void maybe_die(int error_num, const char* fmt_reason, ...) | |
| } | ||
|
|
||
|
|
||
|
|
||
| /* | ||
| Sends a query to server, optionally reads result, prints error message if | ||
| some. | ||
|
|
@@ -1502,27 +1500,64 @@ static void maybe_die(int error_num, const char* fmt_reason, ...) | |
| res if non zero, result will be put there with | ||
| mysql_store_result() | ||
| query query to send to server | ||
| no_parse_error Do not print error message for parse errors | ||
|
|
||
| RETURN VALUES | ||
| 0 query sending and (if res!=0) result reading went ok | ||
| 1 error | ||
| -1 Syntax/parse error (for retry code) | ||
| */ | ||
|
|
||
| static int mysql_query_with_error_report(MYSQL *mysql_con, MYSQL_RES **res, | ||
| const char *query) | ||
| const char *query, | ||
| bool no_parse_error = false) | ||
| { | ||
| DBUG_ASSERT(mysql_con); | ||
| if (mysql_query(mysql_con, query) || | ||
| (res && !((*res)= mysql_store_result(mysql_con)))) | ||
| { | ||
| if (no_parse_error && mysql_errno(mysql_con) == ER_PARSE_ERROR) | ||
| return -1; | ||
| maybe_die(EX_MYSQLERR, "Couldn't execute '%s': %s (%d)", | ||
| query, mysql_error(mysql_con), mysql_errno(mysql_con)); | ||
| query, mysql_error(mysql_con), mysql_errno(mysql_con)); | ||
| return 1; | ||
| } | ||
| return 0; | ||
| } | ||
|
|
||
|
|
||
| /* | ||
| Sends a query to server. In case of parse error try another syntax | ||
| */ | ||
|
|
||
| static int mysql_query_with_retry(MYSQL *mysql_con, MYSQL_RES **res, | ||
| const char *query1, const char *query2) | ||
| { | ||
| int error; | ||
| if ((error= mysql_query_with_error_report(mysql_con, res, query1, 1)) == -1) | ||
| error= mysql_query_with_error_report(mysql_con, res, query2, 0); | ||
|
Comment on lines
+1537
to
+1538
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For better readability and type safety in C++, use if ((error= mysql_query_with_error_report(mysql_con, res, query1, true)) == -1)
error= mysql_query_with_error_report(mysql_con, res, query2, false); |
||
| return error; | ||
| } | ||
|
|
||
| /* | ||
| Get slave status from server. | ||
|
|
||
| Note that MySQL server does not support 'SHOW ALL' and | ||
| multi_source should thus not be set when dumping from MySQL | ||
| */ | ||
|
|
||
| static int show_slave_status(MYSQL *mysql_con, MYSQL_RES **res) | ||
| { | ||
| return (mysql_query_with_retry(mysql_con, res, | ||
| (multi_source ? | ||
| "SHOW ALL REPLICAS STATUS" : | ||
| "SHOW REPLICA STATUS"), | ||
| (multi_source ? | ||
| "SHOW ALL SLAVES STATUS" : | ||
| "SHOW SLAVE STATUS"))); | ||
| } | ||
|
|
||
|
|
||
| static int fetch_db_collation(const char *db_name, | ||
| char *db_cl_name, | ||
| int db_cl_size) | ||
|
|
@@ -6389,8 +6424,9 @@ static int do_show_master_status(MYSQL *mysql_con, int consistent_binlog_pos, | |
| } | ||
| else | ||
| { | ||
| if (mysql_query_with_error_report(mysql_con, &master, | ||
| "SHOW MASTER STATUS")) | ||
| if (mysql_query_with_retry(mysql_con, &master, | ||
| "SHOW MASTER STATUS", | ||
| "SHOW BINARY LOG STATUS")) | ||
| return 1; | ||
|
|
||
| row= mysql_fetch_row(master); | ||
|
|
@@ -6477,10 +6513,7 @@ static int do_stop_slave_sql(MYSQL *mysql_con) | |
| !slave_status_res // do_stop_slave_sql() should only be called once | ||
| ); | ||
|
|
||
| if (mysql_query_with_error_report(mysql_con, &slave_status_res, | ||
| multi_source ? | ||
| "SHOW ALL SLAVES STATUS" : | ||
| "SHOW SLAVE STATUS")) | ||
| if (show_slave_status(mysql_con, &slave_status_res)) | ||
| return(1); | ||
|
|
||
| /* Loop over all slaves */ | ||
|
|
@@ -6493,7 +6526,8 @@ static int do_stop_slave_sql(MYSQL *mysql_con) | |
| { | ||
| char query[160]; | ||
| if (multi_source) | ||
| snprintf(query, sizeof(query), "STOP SLAVE '%.80s' SQL_THREAD", row[0]); | ||
| snprintf(query, sizeof(query), "STOP SLAVE '%.80s' SQL_THREAD", | ||
| row[0]); | ||
| else | ||
| strmov(query, "STOP SLAVE SQL_THREAD"); | ||
|
|
||
|
|
@@ -6542,10 +6576,7 @@ static int do_show_slave_status(MYSQL *mysql_con, int have_mariadb_gtid, | |
| const char *gtid_comment_prefix= (use_gtid ? comment_prefix : "-- "); | ||
| const char *nogtid_comment_prefix= (!use_gtid ? comment_prefix : "-- "); | ||
|
|
||
| if (mysql_query_with_error_report(mysql_con, &slave, | ||
| multi_source ? | ||
| "SHOW ALL SLAVES STATUS" : | ||
| "SHOW SLAVE STATUS")) | ||
| if (show_slave_status(mysql_con, &slave)) | ||
| { | ||
| if (!ignore_errors) | ||
| { | ||
|
|
@@ -6705,8 +6736,9 @@ static int get_bin_log_name(MYSQL *mysql_con, | |
| MYSQL_RES *res; | ||
| MYSQL_ROW row; | ||
|
|
||
| if (mysql_query(mysql_con, "SHOW MASTER STATUS") || | ||
| !(res= mysql_store_result(mysql))) | ||
| if (mysql_query_with_retry(mysql_con, &res, | ||
| "SHOW MASTER STATUS", | ||
| "SHOW BINARY LOG STATUS")) | ||
| return 1; | ||
|
|
||
| if (!(row= mysql_fetch_row(res))) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a large number of changes (such as
mysqldumpupdates, InnoDB buffer pool/transaction vector refactoring, and Groonga warning fixes) that are completely unrelated to the SBOM supplier name fix described in the PR title and description. According to the general rules, unrelated optimizations or bug fixes should be addressed in separate pull requests targeted at the earliest applicable branch rather than being bundled into the current pull request. Please split these unrelated changes into their own dedicated pull requests.References