MDEV-38405 Assertion `tbl->trn == 0' failed in _ma_set_trn_for_table#5119
Open
grooverdan wants to merge 1 commit into
Open
MDEV-38405 Assertion `tbl->trn == 0' failed in _ma_set_trn_for_table#5119grooverdan wants to merge 1 commit into
grooverdan wants to merge 1 commit into
Conversation
Aria bulk insert operations disables share->now_transaction meaning a concurrent open of the stable table will have tbl->trn == &dummy_transaction_object for its handler object during opening. As the _ma_set_trn_for_table is setting the trn, its harmless if the current trn is the dummy_transaction_object. Relax the assert to allow for this state.
grooverdan
added
the
MariaDB Foundation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the _ma_set_trn_for_table function in storage/maria/ma_trnman.h to relax a debug assertion. The update allows tbl->trn to be either null or equal to the dummy_transaction_object when assigning a new transaction, whereas the previous implementation strictly required it to be null. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aria bulk insert operations disables share->now_transaction meaning a concurrent open of the stable table will have
tbl->trn == &dummy_transaction_object for its handler object during opening.
As the _ma_set_trn_for_table is setting the trn, its harmless if the current trn is the dummy_transaction_object.
Relax the assert to allow for this state.