MDEV-34817: Performance schema is not cleared of removed package routines

[kjarir]

Problem

When DROP DATABASE or DROP PACKAGE BODY is executed, sp_drop_db_routines() was not calling MYSQL_DROP_SP for Oracle-style package body sub-routines. This caused stale ghost rows to remain in events_statements_summary_by_program, making the MTR test perfschema.lowercase_fs_off fail non-deterministically when run after compat/oracle.sp-package.

Fix

1. In sp_drop_routine_internal: iterate sub-routines and call MYSQL_DROP_SP before removing the package from cache.
2. In sp_drop_db_routines: use the thread's package body cache to identify and clear sub-routines when a package body is dropped during DROP DATABASE.

Testing

• Added regression test: perfschema.mdev34817
• Verified with: ./mtr --no-reorder compat/oracle.sp-package perfschema.lowercase_fs_off --repeat=5
• Full perfschema suite passes

References

Closes MDEV-34817
Closes MDEV-35282

[grooverdan]

As 10.11 is affected too, sorry it wasn't obvious on the bug, back port this to there. Note a few variable constructs are different, but the compiler will find them.

There's a test case for DROP DATABASE, but as your implementation highlights, DROP PACKAGE/ DROP PACKAGE BODY are also affected. Just testing one of these is sufficient as both end up in sp_drop_routine_internal.

Lastly, the improved commit message header is better than the previous MDEV title. But I think the title I rename this PR is clearer again so please use that. There should be a body in the commit message describing the problem and correction.

[kjarir]

Thanks for the detailed review @grooverdan. Working through all the points now, will push an updated version shortly with the static helper, improved test formatting, DROP PACKAGE test case, and updated commit message.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 12 committers have signed the CLA.

✅ abhishek593
✅ gkodinov
✅ FaramosCZ
✅ spetrunia
✅ grooverdan
✅ mariadb-RexJohnston
✅ ParadoxV5
✅ kjarir
✅ HNOONa-0
❌ mariadb-YuchenPei
❌ montywi
❌ vuvova
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[grooverdan]

Its currently failing on embedded tests.

--- /home/buildbot/amd64-debian-11-debug-ps-embedded/build/mysql-test/suite/compat/oracle/r/perfschema.result	2026-04-16 06:40:34.000000000 +0000
+++ /home/buildbot/amd64-debian-11-debug-ps-embedded/build/mysql-test/suite/compat/oracle/r/perfschema.reject	2026-04-16 06:45:26.326364209 +0000
@@ -40,7 +40,6 @@
 FROM performance_schema.events_statements_summary_by_program
 WHERE LOWER(object_schema)='mdev34817_db';
 object_type	object_schema	object_name
-	mdev34817_db	pkg1
 DROP DATABASE mdev34817_db;

I suspect that a --source include/not_embedded.inc might be needed as many of mysql-test/suite/compat/oracle/t around stored procedures already do. I'm going to leave this as a call to the second reviewer so no need to address this immediately.