Skip to content

fix(extension): capture keyboard submissions#6

Merged
MarcoAntolini merged 7 commits into
mainfrom
issue-4-cmd-enter-submission
Jun 17, 2026
Merged

fix(extension): capture keyboard submissions#6
MarcoAntolini merged 7 commits into
mainfrom
issue-4-cmd-enter-submission

Conversation

@MarcoAntolini

@MarcoAntolini MarcoAntolini commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds keyboard submit shortcut detection for Cmd+Enter and Ctrl+Enter on CSSBattle play pages.
  • Wires shortcut submissions into the same content-script ingestion path used by submit clicks.
  • Covers shortcut detection with focused unit tests.

Test plan

  • npm --workspace @csshub/extension run test -- tests/unit/contentScript.dom.test.ts (red before implementation, green after)
  • npm run build --workspace @csshub/shared
  • npm --workspace @csshub/extension run test
  • npm run typecheck

Issue

Fixes #4

Handle CSSBattle keyboard submit shortcuts through the same ingestion path as submit clicks so shortcut users still sync to GitHub.
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
css-hub-extension Ready Ready Preview, Comment Jun 17, 2026 10:37am

Minify custom extension bundles, refresh bundle budgets to the current production baseline, and update Vitest past the critical audit advisory.
Keep the Windows npm shell workaround out of the generic command runner so Fallow's new-code complexity gate passes.
Keep the mocked cssbattleSubmission E2E fixture aligned with the production commit path, which requires a captured preview image before syncing to GitHub.
Capture CSSBattle submit shortcuts from the page world so Ctrl+Enter users reach the same submission ingestion path as click submissions.
Reduce branch-heavy shortcut guard helpers so the PR quality audit passes without changing keyboard submission behavior.
@MarcoAntolini MarcoAntolini merged commit 5321147 into main Jun 17, 2026
6 checks passed
@MarcoAntolini MarcoAntolini deleted the issue-4-cmd-enter-submission branch June 17, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: CMD + Enter doesn't count as a submission

1 participant