fix: apply EmptyCollectionIfNull to record constructor args (#943)#973
Closed
leno23 wants to merge 2 commits into
Closed
fix: apply EmptyCollectionIfNull to record constructor args (#943)#973leno23 wants to merge 2 commits into
leno23 wants to merge 2 commits into
Conversation
…apper#943) Apply destination transforms when null-propagation is skipped for ctor parameters and when building record constructor arguments. Co-authored-by: Cursor <cursoragent@cursor.com>
…erMapper#943, MapsterMapper#952) Do not apply EmptyCollectionIfNull when a member has an explicit Map resolver, including record constructor parameters. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Heads-up for review: #943 ctor-path transforms were partially addressed upstream in #945 ( |
Author
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmptyCollectionIfNull(and other destination transforms) to record/class constructor arguments when null sources would otherwise skip transforms..Map()resolver so explicit null mappings are preserved.Fixes #943
Relates to #952 (ctor-parameter path; property path covered by #966)
Test plan
NullableCtorPropagationCurrentWorkWithDestinationTransform(EmptyCollectionIfNull no longer initializes empty collections in reccords for nullable source #943)ExplicitNullMapping_ShouldNotBeOverridden_ByDefaultEmptyCollectionTransform(DestinationTransform.EmptyCollectionIfNull overrides explicit null mapping #952)development