fix: use type default for optional DateTime constructor params (#954)#968
Closed
leno23 wants to merge 1 commit into
Closed
fix: use type default for optional DateTime constructor params (#954)#968leno23 wants to merge 1 commit into
leno23 wants to merge 1 commit into
Conversation
…erMapper#954) When an optional constructor parameter has a null/DBNull default value, emit destinationType.CreateDefault() instead of Expression.Constant(null). Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hi, @leno23 Thanks, but it is fixed. and in net48 and perhaps in netcore version 6 or below, instead of the default value being null, the default value actually contains a FormatException. |
DocSvartz
reviewed
May 25, 2026
| static Expression CreateOptionalParameterDefault(ParameterInfo parameterInfo, Type destinationType) | ||
| { | ||
| var defaultValue = parameterInfo.DefaultValue; | ||
| if (defaultValue == null || defaultValue is DBNull) |
Contributor
There was a problem hiding this comment.
@leno23 defaultValue is DBNull Please add a test for this case if it applies. There is already a test for the general case.
Author
|
Thanks @DocSvartz — confirmed the Appreciate the note about net48 / net6-or-below default-value behavior vs null. |
Author
|
Superseded by fix already on development branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateOptionalParameterDefaultfor optional constructor parameters.DefaultValueis null orDBNull, emitdestinationType.CreateDefault()instead ofExpression.Constant(null, valueType).DateTimeto a class with an optionalDateTimeconstructor parameter.Fixes #954
Test plan
WhenMappingRecordWithOptionalDateTimeConstructorregression testdevelopment